Skip to content

Tighten dispatch verification and drop unnecessary summary dep#1667

Merged
stranske merged 1 commit intomainfrom
claude/fix-task-completion-concerns-I1gRT
Feb 26, 2026
Merged

Tighten dispatch verification and drop unnecessary summary dep#1667
stranske merged 1 commit intomainfrom
claude/fix-task-completion-concerns-I1gRT

Conversation

@stranske
Copy link
Copy Markdown
Owner

@stranske stranske commented Feb 26, 2026

Source: Issue #1665

Automated Status Summary

Scope

Observed on stranske/Counter_Risk#34: the auto-pilot dispatched the belt, but the GitHub Actions run was silently cancelled before receiving a runner (empty logs, null cancel_actor). No retry existed, so the keepalive loop waited through 5 exponential-backoff cycles (~30 min total), then stalled with needs-human.

Context for Agent

Related Issues/PRs

Tasks

  • Adds retry logic (up to 3 attempts with 15s verification) to the capability-check belt dispatch so a single cancelled run doesn't strand an issue
  • Adds re-dispatch in the branch-check backoff loop so the auto-pilot can self-heal instead of passively waiting and then stalling

Acceptance criteria

  • YAML validates (yaml.safe_load)
  • JS syntax passes (node --check in async wrapper)
  • Retry loop caps at 3 attempts and doesn't retry on the final attempt
  • Branch-check re-dispatch only fires when no dispatcher run is alive
  • Existing happy-path (dispatch succeeds first try) exits loop immediately

Head SHA: 48c2cca
Latest Runs: ✅ success — Gate
Required: gate: ✅ success

Workflow / Job Result Logs
.github/workflows/autofix.yml ❌ failure View run
Agents PR meta manager ❔ in progress View run
Auto-label Dependabot PRs ⏭️ skipped View run
Copilot code review ✅ success View run
Gate ✅ success View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ✅ success View run
Health 45 Agents Guard ✅ success View run
Health 50 Security Scan ✅ success View run
Health 73 Template Completeness ✅ success View run
Health 74 Template Drift ✅ success View run
Keepalive E2E ✅ success View run
Maint 52 Validate Workflows ✅ success View run
PR 11 - Minimal invariant CI ✅ success View run
Selftest CI ✅ success View run
Validate Sync Manifest ✅ success View run

- Remove progress-review from summary job needs in keepalive-loop
  (summary doesn't consume its outputs; avoids breaking non-review runs)
- Add event === 'workflow_dispatch' filter to all dispatch run-matching
  in auto-pilot capability-check and branch-check steps, preventing
  false positives from schedule/push-triggered runs

https://claude.ai/code/session_01JhCWWDJG8PqwaSbVPCGfm6
Copilot AI review requested due to automatic review settings February 26, 2026 18:53
@stranske stranske temporarily deployed to agent-high-privilege February 26, 2026 18:53 — with GitHub Actions Inactive
@stranske-keepalive
Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 194b109
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 93.12%
Baseline 85.00%
Delta +8.12%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
src/cli_parser.py 81.8% 4
src/percentile_calculator.py 95.0% 1
src/aggregator.py 95.0% 2
src/__init__.py 100.0% 0
src/ndjson_parser.py 100.0% 0

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens dispatch verification logic and removes an unnecessary job dependency to improve reliability. It addresses review feedback from PR #1665 which added belt dispatcher retry logic to prevent auto-pilot stalls.

Changes:

  • Remove progress-review from summary job dependencies in keepalive-loop workflows to prevent potential issues when progress-review is skipped during non-review iterations
  • Add r.event === 'workflow_dispatch' filter to belt dispatcher run verification in auto-pilot workflows to prevent false positives from runs triggered by other event types (workflow_call, schedule, etc.)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
templates/consumer-repo/.github/workflows/agents-keepalive-loop.yml Remove progress-review from summary job needs list (template)
templates/consumer-repo/.github/workflows/agents-auto-pilot.yml Add event type filter to both dispatch verification locations (template)
.github/workflows/agents-keepalive-loop.yml Remove progress-review from summary job needs list (main)
.github/workflows/agents-auto-pilot.yml Add event type filter to both dispatch verification locations (main)

@stranske-keepalive
Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #1667 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Disposition skipped (transient)
Gate success
Tasks 0/7 complete
Timeout 45 min (default)
Timeout usage 3m elapsed (8%, 42m remaining)
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

@stranske-keepalive
Copy link
Copy Markdown
Contributor

Keepalive Work Log (click to expand)
# Time (UTC) Agent Action Result Files Tasks Progress Commit Gate
0 2026-02-26 18:57:11 Codex wait (missing-agent-label-transient) skipped 0 0/7 success

@stranske stranske merged commit e97db2f into main Feb 26, 2026
134 of 137 checks passed
@stranske stranske deleted the claude/fix-task-completion-concerns-I1gRT branch February 26, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants