Skip to content

fix: label sync workflow js-yaml install #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 13 commits into from
Feb 26, 2026
Merged

fix: label sync workflow js-yaml install #1662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
02064f0
fix: avoid multi-line stderr in workflow annotations
claude Feb 25, 2026
4d84c1f
fix: sync template setup-api-client with retry-with-backoff and annot…
claude Feb 25, 2026
c36adc1
fix: pre-timeout watchdog, robust parser import, and always-commit sa…
claude Feb 25, 2026
7924d1e
fix: preserve indented checkbox states in PR Meta body sync
claude Feb 26, 2026
6145c5e
chore: sync template scripts
github-actions[bot] Feb 26, 2026
6811187
fix: address review comments on watchdog pre-timeout mechanism
claude Feb 26, 2026
0b9a46c
docs: add watchdog-saved to workflow outputs reference
claude Feb 26, 2026
97056c0
fix: skip non-issue refs like "Run #NNN" in extractIssueNumberFromPull
claude Feb 26, 2026
96e5f6e
feat: add session analysis, completion comment, and error diagnostics…
claude Feb 26, 2026
9280958
fix: address code review feedback from Codex and Copilot
claude Feb 26, 2026
f8737e8
merge: resolve conflicts with main (keep watchdog improvements)
claude Feb 26, 2026
65e89c5
fix: address sync PR review feedback from coding agents
claude Feb 26, 2026
9e89707
fix: install js-yaml locally instead of globally in label sync workflow
claude Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/setup-api-client/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,9 @@ runs:
echo "$npm_err"
echo "::endgroup::"

# On first failure, also try --legacy-peer-deps in case it's a peer dep conflict
if [ "$attempt" -eq 1 ]; then
echo "::warning::Retrying with --legacy-peer-deps"
# On peer-dep / ERESOLVE failures, also try --legacy-peer-deps
if echo "$npm_err" | grep -qiE 'ERESOLVE|peer dep|Could not resolve dependency'; then
echo "::warning::Detected peer dependency conflict, retrying with --legacy-peer-deps"
npm_output=$(mktemp)
if npm install --no-save --legacy-peer-deps --location=project "${NPM_PACKAGES[@]}" 2>"$npm_output"; then
rm -f "$npm_output"
Expand Down
5 changes: 5 additions & 0 deletions .github/scripts/__tests__/agents-pr-meta-keepalive.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,11 @@ test('extractIssueNumberFromPull skips "step #N" in body', () => {
assert.equal(extractIssueNumberFromPull(pull), null);
});

test('extractIssueNumberFromPull treats "Task #N" as a valid issue ref', () => {
const pull = { body: 'Task #42 is ready for review', head: { ref: 'feature' }, title: 'stuff' };
assert.equal(extractIssueNumberFromPull(pull), 42);
});

test('extractIssueNumberFromPull skips "version #N" in body', () => {
const pull = { body: 'Upgraded to version #4', head: { ref: 'feature' }, title: 'stuff' };
assert.equal(extractIssueNumberFromPull(pull), null);
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/agents_pr_meta_keepalive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ function extractIssueNumberFromPull(pull) {
}
// Skip non-issue refs like "Run #123", "run #123", "attempt #2"
const preceding = bodyText.slice(Math.max(0, match.index - 20), match.index);
if (/\b(?:run|attempt|step|job|check|task|version|v)\s*$/i.test(preceding)) {
if (/\b(?:run|attempt|step|job|check|version|v)\s*$/i.test(preceding)) {
continue;
}
candidates.push(match[1]);
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/maint-69-sync-labels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
github_token: ${{ github.token }}

- name: Install js-yaml
run: npm install -g js-yaml
run: npm install js-yaml
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install js-yaml will create/update package-lock.json (and potentially run install scripts), which is inconsistent with the repo’s other workflows that install one-off Node deps using --no-save --no-package-lock to avoid workspace churn. Consider installing js-yaml with --no-save --no-package-lock (and optionally --ignore-scripts) to keep the workspace clean and reduce supply-chain risk.

Suggested change
run: npm install js-yaml
run: npm install js-yaml --no-save --no-package-lock --ignore-scripts

Copilot uses AI. Check for mistakes.

- name: Parse labels-core.yml
id: parse
Expand Down
Loading
Loading