Skip to content

fix: remove duplicate else clause in verifier CI-wait step#1642

Merged
stranske merged 1 commit intomainfrom
claude/fix-verifier-else-88W3o
Feb 23, 2026
Merged

fix: remove duplicate else clause in verifier CI-wait step#1642
stranske merged 1 commit intomainfrom
claude/fix-verifier-else-88W3o

Conversation

@stranske
Copy link
Copy Markdown
Owner

@stranske stranske commented Feb 23, 2026

Source: Issue #208

Automated Status Summary

Scope

  • Scope section missing from source issue.

Tasks

  • Tasks section missing from source issue.

Acceptance criteria

  • Acceptance criteria section missing from source issue.

  • Head SHA: 55b15cb

  • Latest Runs: ⏹️ cancelled — Gate

  • Required: gate: ⏹️ cancelled

  • | Workflow / Job | Result | Logs |

  • |----------------|--------|------|

  • | Agents PR meta manager | ❔ in progress | View run |

  • | CI Autofix Loop | ✅ success | View run |

  • | Copilot code review | ❔ in progress | View run |

  • | Gate | ⏹️ cancelled | View run |

  • | Health 40 Sweep | ✅ success | View run |

  • | Health 44 Gate Branch Protection | ✅ success | View run |

  • | Health 45 Agents Guard | ✅ success | View run |

  • | Health 50 Security Scan | ❔ in progress | View run |

  • | Health 67 Integration Sync Check | ✅ success | View run |

  • | Maint 52 Validate Workflows | ✅ success | View run |

  • | PR 11 - Minimal invariant CI | ✅ success | View run |

  • | Selftest CI | ❔ in progress | View run |

Head SHA: 16c1af5
Latest Runs: ✅ success — Gate
Required: gate: ✅ success

Workflow / Job Result Logs
.github/workflows/autofix.yml ❌ failure View run
Agents PR meta manager ❔ in progress View run
Auto-label Dependabot PRs ⏭️ skipped View run
Copilot code review ✅ success View run
Gate ✅ success View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ✅ success View run
Health 45 Agents Guard ✅ success View run
Health 50 Security Scan ✅ success View run
Health 73 Template Completeness ✅ success View run
Maint 52 Validate Workflows ✅ success View run
PR 11 - Minimal invariant CI ✅ success View run
Selftest CI ✅ success View run
Validate Sync Manifest ✅ success View run

The catch block in "Wait for CI workflows to complete" had two
consecutive else clauses, causing SyntaxError: Unexpected token else.
Merge the workflowState.set() call into the single else branch so
non-rate-limit API errors still update workflow state.

https://claude.ai/code/session_012WnYCcttvFEY3FETnhVcNL
Copilot AI review requested due to automatic review settings February 23, 2026 15:13
@stranske stranske temporarily deployed to agent-high-privilege February 23, 2026 15:13 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a JavaScript syntax error in the CI-wait polling step of the verifier workflow. The bug prevented verification from running on consumer repos due to a duplicate else clause that caused an immediate SyntaxError: Unexpected token 'else' crash. The fix correctly merges the workflowState.set() call into the single else branch so that non-rate-limit API errors still properly update the workflow state.

Changes:

  • Removed duplicate else clause on line 253 in reusable-agents-verifier.yml
  • The workflowState.set() call now properly executes in the existing else block for non-rate-limit errors

@agents-workflows-bot
Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: a2d3485
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 93.12%
Baseline 85.00%
Delta +8.12%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
src/cli_parser.py 81.8% 4
src/percentile_calculator.py 95.0% 1
src/aggregator.py 95.0% 2
src/__init__.py 100.0% 0
src/ndjson_parser.py 100.0% 0

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@stranske-keepalive
Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #1642 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Disposition skipped (transient)
Gate success
Tasks 0/19 complete
Timeout 45 min (default)
Timeout usage 3m elapsed (9%, 42m remaining)
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

@stranske stranske merged commit bb08fa8 into main Feb 23, 2026
164 of 166 checks passed
@stranske stranske deleted the claude/fix-verifier-else-88W3o branch February 23, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants