Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"minimatch": "0.0.0-local"
"minimatch": "3.0.5"
Comment on lines 3 to +4
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use correct minimatch import for v3

Upgrading .github/scripts/package.json to minimatch@3.0.5 switches to the CommonJS default export (module.exports = minimatch), but scripts in this repo import with destructuring (e.g., const { minimatch } = require('minimatch') in merge_manager.js and pr-context-graphql.js). With v3 this evaluates to undefined, so calls like minimatch(filename, pattern, …) will throw at runtime whenever those scripts execute. Either update the import sites to const minimatch = require('minimatch') or pin a version that still provides a named export.

Useful? React with 👍 / 👎.

}
}
Loading