fix: Update download-artifact from v7 to v4 in bridge workflow

[stranske]

Source: Issue #1372

Automated Status Summary

Scope

PR #1367 addressed issue #1365, but verification flagged CONCERNS due to gaps in how tests validate internal behavior (notably max_repair_attempts effective handling and quality_context forwarding) and potential missing/pinned dependencies. This follow-up tightens test assertions to observe real call sites (spies/mocks), verifies identity-forwarding robustly (positional + keyword), fixes a client signature mismatch, and pins dependencies for reproducible, fresh-env test runs.

Context for Agent

Related Issues/PRs

• stranske/Workflows#1367
• stranske/Workflows#1365
• #1367
• #1365
• #1371

Tasks

• Update tests/test_structured_output.py to parameterize max_repair_attempts over [0, 1, 2, 10] and assert the effective value by spying on the repair-loop invocation (capture the argument passed into the repair loop). Set expected effective values to match the production rule (clamp vs no-clamp) and add an inline comment describing that rule.
  • Define scope for: Update tests/test_structured_output.py to parameterize max_repair_attempts over `[0 (verify: tests pass)
  • Implement focused slice for: Update tests/test_structured_output.py to parameterize max_repair_attempts over `[0 (verify: tests pass)
  • Validate focused slice for: Update tests/test_structured_output.py to parameterize max_repair_attempts over `[0 (verify: tests pass)
  • 1 (verify: confirm completion in repo)
  • 2 (verify: confirm completion in repo)
  • Define scope for: assert the effective value by spying on the repair-loop invocation (capture the argument passed into the repair loop). Set expected effective values to match the production rule (clamp vs no-clamp) (verify: confirm completion in repo)
  • Implement focused slice for: assert the effective value by spying on the repair-loop invocation (capture the argument passed into the repair loop). Set expected effective values to match the production rule (clamp vs no-clamp) (verify: confirm completion in repo)
  • Validate focused slice for: assert the effective value by spying on the repair-loop invocation (capture the argument passed into the repair loop). Set expected effective values to match the production rule (clamp vs no-clamp) (verify: confirm completion in repo) add an inline comment describing that rule. (verify: confirm completion in repo)
• Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with at least two providers, call analyze_completion once with a unique sentinel quality_context, assert the selected provider method is called exactly once, and verify quality_context forwarding by identity by inspecting both call_args.args and call_args.kwargs (explicitly assert kwargs['quality_context'] is sentinel when present).
  • Define scope for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with at least two providers (verify: tests pass)
  • Implement focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with at least two providers (verify: tests pass)
  • Validate focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with at least two providers (verify: tests pass)
  • Define scope for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call analyze_completion once with a unique sentinel quality_context (verify: tests pass)
  • Implement focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call analyze_completion once with a unique sentinel quality_context (verify: tests pass)
  • Validate focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call analyze_completion once with a unique sentinel quality_context (verify: tests pass)
  • Define scope for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with assert the selected provider method is called exactly once (verify: tests pass)
  • Implement focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with assert the selected provider method is called exactly once (verify: tests pass)
  • Validate focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with assert the selected provider method is called exactly once (verify: tests pass)
  • Define scope for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with (verify: tests pass)
  • Implement focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with (verify: tests pass)
  • Validate focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with (verify: tests pass) verify quality_context forwarding by identity by inspecting both call_args.args
  • Define scope for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call_args.kwargs (explicitly assert kwargs['quality_context'] is sentinel when present). (verify: tests pass)
  • Implement focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call_args.kwargs (explicitly assert kwargs['quality_context'] is sentinel when present). (verify: tests pass)
  • Validate focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call_args.kwargs (explicitly assert kwargs['quality_context'] is sentinel when present). (verify: tests pass)
• Adjust tests/test_anthropic_provider.py so DummyClient.invoke accepts the positional/keyword pattern used by the provider (e.g., *args, **kwargs), and add assertions that invoke is called exactly once and that invoke.call_args.kwargs['quality_context'] is sentinel.
  • Define scope for: Adjust tests/test_anthropic_provider.py so DummyClient.invoke accepts the positional/keyword pattern used by the provider (e.g. (verify: tests pass)
  • Implement focused slice for: Adjust tests/test_anthropic_provider.py so DummyClient.invoke accepts the positional/keyword pattern used by the provider (e.g. (verify: tests pass)
  • Validate focused slice for: Adjust tests/test_anthropic_provider.py so DummyClient.invoke accepts the positional/keyword pattern used by the provider (e.g. (verify: tests pass)
  • `*args (verify: confirm completion in repo)
  • *kwargs`) (verify: confirm completion in repo)
  • Define scope for: add assertions that invoke is called exactly once (verify: confirm completion in repo)
  • Implement focused slice for: add assertions that invoke is called exactly once (verify: confirm completion in repo)
  • Validate focused slice for: add assertions that invoke is called exactly once (verify: confirm completion in repo)
  • Define scope for: that invoke.call_args.kwargs['quality_context'] is sentinel. (verify: confirm completion in repo)
  • Implement focused slice for: that invoke.call_args.kwargs['quality_context'] is sentinel. (verify: confirm completion in repo)
  • Validate focused slice for: that invoke.call_args.kwargs['quality_context'] is sentinel. (verify: confirm completion in repo)
• Review test-suite imports and add any missing runtime dependencies to requirements.txt, pinning langchain-community and requests with exact == versions and adding any other required packages with exact pins where feasible.
  • Review test-suite imports (verify: confirm completion in repo) add any missing runtime dependencies to requirements.txt (verify: dependencies updated) pinning langchain-community (verify: dependencies updated)
  • requests with exact == versions (verify: dependencies updated)
  • Define scope for: requests with adding any other required packages with exact pins where feasible. (verify: dependencies updated)
  • Implement focused slice for: requests with adding any other required packages with exact pins where feasible. (verify: dependencies updated)
  • Validate focused slice for: requests with adding any other required packages with exact pins where feasible. (verify: dependencies updated)

Acceptance criteria

• tests/test_structured_output.py contains a single parameterized test case over max_repair_attempts values [0, 1, 2, 10] (e.g., via pytest.mark.parametrize) and the test asserts the effective value used internally by capturing the argument passed to the repair-loop invocation (spy/mock on the repair-loop callsite, not by directly calling internal helper functions).
• For each input value in [0, 1, 2, 10], the structured-output test asserts that the captured repair-loop argument equals the expected effective value according to the production rule (either unchanged or clamped), and the expected mapping is explicitly encoded in the test (e.g., an expected_effective parameter) rather than inferred at runtime.
• The structured-output test includes an inline comment adjacent to the expectation that states the production rule for max_repair_attempts (e.g., “value is clamped to X” or “value is not clamped; forwarded as-is”), so that changing production behavior requires updating the comment and expected values together.
• tests/test_fallback_chain_provider.py constructs a FallbackChainProvider using at least two distinct underlying provider instances/mocks and invokes analyze_completion(...) exactly once with a unique sentinel = object() passed as quality_context.
• In the strengthened fallback-chain test, the selected/active underlying provider method (the one expected to handle the call) is asserted to have been called exactly once, and all other underlying provider methods are asserted not to have been called (call count == 0).
• The fallback-chain test verifies quality_context forwarding by identity by inspecting both call_args.args and call_args.kwargs, and includes an explicit assertion call_args.kwargs['quality_context'] is sentinel when the kwarg is present.
• In tests/test_anthropic_provider.py, DummyClient.invoke is defined with a signature that can accept the provider call pattern (must accept *args and **kwargs), so the test does not fail due to TypeError from argument mismatch.
• The anthropic-provider test asserts DummyClient.invoke is called exactly once during the operation under test (e.g., invoke.assert_called_once()), not merely that it was called.
• The anthropic-provider test passes a sentinel = object() as quality_context and asserts identity forwarding via DummyClient.invoke.call_args.kwargs['quality_context'] is sentinel.
• requirements.txt contains exact version pins (using ==) for both langchain-community and requests (no ranges like >= or unpinned entries for these two packages).
• Any additional packages required to import all modules exercised by the test suite are added to requirements.txt with exact == pins where feasible, and running python -m pytest -q in a fresh environment created from requirements.txt completes without ModuleNotFoundError.

Head SHA: 4889263
Latest Runs: ✅ success — Gate
Required: gate: ✅ success

Workflow / Job	Result	Logs
Agents PR meta manager	❔ in progress	View run
CI Autofix Loop	✅ success	View run
Gate	✅ success	View run
Health 40 Sweep	✅ success	View run
Health 44 Gate Branch Protection	✅ success	View run
Health 45 Agents Guard	✅ success	View run
Health 50 Security Scan	✅ success	View run
Health 73 Template Completeness	✅ success	View run
Health 74 Template Drift	✅ success	View run
Maint 52 Validate Workflows	✅ success	View run
PR 11 - Minimal invariant CI	✅ success	View run
Selftest CI	✅ success	View run
Validate Sync Manifest	✅ success	View run

[Copilot]

Pull request overview

Fixes broken bridge workflows by replacing a nonexistent GitHub Action version (actions/download-artifact@v7) with the valid current major version (@v4) so the follow-up issue metadata can be downloaded and auto-pilot dispatch can proceed.

Changes:

• Update actions/download-artifact from @v7 to @v4 in the main bridge workflow
• Mirror the same fix in the consumer-repo workflow template

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
.github/workflows/agents-verify-to-new-pr-autopilot.yml	Fixes workflow execution by using an existing download-artifact major version.
templates/consumer-repo/.github/workflows/agents-verify-to-new-pr-autopilot.yml	Keeps the consumer template consistent with the corrected action version.

[stranske-keepalive]

Automated Status Summary

Head SHA: d92c75e
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job	Result	Logs
(no jobs reported)	⏳ pending	—

Coverage Overview

• Coverage history entries: 1

Coverage Trend

Metric	Value
Current	93.12%
Baseline	85.00%
Delta	+8.12%
Minimum	70.00%
Status	✅ Pass

Top Coverage Hotspots (lowest coverage)

File	Coverage	Missing
src/cli_parser.py	81.8%	4
src/percentile_calculator.py	95.0%	1
src/aggregator.py	95.0%	2
src/__init__.py	100.0%	0
src/ndjson_parser.py	100.0%	0

Updated automatically; will refresh on subsequent CI/Docker completions.

---

Keepalive checklist

Scope

PR #1367 addressed issue #1365, but verification flagged CONCERNS due to gaps in how tests validate internal behavior (notably max_repair_attempts effective handling and quality_context forwarding) and potential missing/pinned dependencies. This follow-up tightens test assertions to observe real call sites (spies/mocks), verifies identity-forwarding robustly (positional + keyword), fixes a client signature mismatch, and pins dependencies for reproducible, fresh-env test runs.

Context for Agent

Related Issues/PRs

• stranske/Workflows#1367
• stranske/Workflows#1365
• #1367
• #1365
• #1371

Tasks

• Update tests/test_structured_output.py to parameterize max_repair_attempts over [0, 1, 2, 10] and assert the effective value by spying on the repair-loop invocation (capture the argument passed into the repair loop). Set expected effective values to match the production rule (clamp vs no-clamp) and add an inline comment describing that rule.
  • Define scope for: Update tests/test_structured_output.py to parameterize max_repair_attempts over `[0 (verify: tests pass)
  • Implement focused slice for: Update tests/test_structured_output.py to parameterize max_repair_attempts over `[0 (verify: tests pass)
  • Validate focused slice for: Update tests/test_structured_output.py to parameterize max_repair_attempts over `[0 (verify: tests pass)
  • 1 (verify: confirm completion in repo)
  • 2 (verify: confirm completion in repo)
  • Define scope for: assert the effective value by spying on the repair-loop invocation (capture the argument passed into the repair loop). Set expected effective values to match the production rule (clamp vs no-clamp) (verify: confirm completion in repo)
  • Implement focused slice for: assert the effective value by spying on the repair-loop invocation (capture the argument passed into the repair loop). Set expected effective values to match the production rule (clamp vs no-clamp) (verify: confirm completion in repo)
  • Validate focused slice for: assert the effective value by spying on the repair-loop invocation (capture the argument passed into the repair loop). Set expected effective values to match the production rule (clamp vs no-clamp) (verify: confirm completion in repo) add an inline comment describing that rule. (verify: confirm completion in repo)
• Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with at least two providers, call analyze_completion once with a unique sentinel quality_context, assert the selected provider method is called exactly once, and verify quality_context forwarding by identity by inspecting both call_args.args and call_args.kwargs (explicitly assert kwargs['quality_context'] is sentinel when present).
  • Define scope for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with at least two providers (verify: tests pass)
  • Implement focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with at least two providers (verify: tests pass)
  • Validate focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with at least two providers (verify: tests pass)
  • Define scope for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call analyze_completion once with a unique sentinel quality_context (verify: tests pass)
  • Implement focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call analyze_completion once with a unique sentinel quality_context (verify: tests pass)
  • Validate focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call analyze_completion once with a unique sentinel quality_context (verify: tests pass)
  • Define scope for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with assert the selected provider method is called exactly once (verify: tests pass)
  • Implement focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with assert the selected provider method is called exactly once (verify: tests pass)
  • Validate focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with assert the selected provider method is called exactly once (verify: tests pass)
  • Define scope for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with (verify: tests pass)
  • Implement focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with (verify: tests pass)
  • Validate focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with (verify: tests pass) verify quality_context forwarding by identity by inspecting both call_args.args
  • Define scope for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call_args.kwargs (explicitly assert kwargs['quality_context'] is sentinel when present). (verify: tests pass)
  • Implement focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call_args.kwargs (explicitly assert kwargs['quality_context'] is sentinel when present). (verify: tests pass)
  • Validate focused slice for: Strengthen tests/test_fallback_chain_provider.py to build a FallbackChainProvider with call_args.kwargs (explicitly assert kwargs['quality_context'] is sentinel when present). (verify: tests pass)
• Adjust tests/test_anthropic_provider.py so DummyClient.invoke accepts the positional/keyword pattern used by the provider (e.g., *args, **kwargs), and add assertions that invoke is called exactly once and that invoke.call_args.kwargs['quality_context'] is sentinel.
  • Define scope for: Adjust tests/test_anthropic_provider.py so DummyClient.invoke accepts the positional/keyword pattern used by the provider (e.g. (verify: tests pass)
  • Implement focused slice for: Adjust tests/test_anthropic_provider.py so DummyClient.invoke accepts the positional/keyword pattern used by the provider (e.g. (verify: tests pass)
  • Validate focused slice for: Adjust tests/test_anthropic_provider.py so DummyClient.invoke accepts the positional/keyword pattern used by the provider (e.g. (verify: tests pass)
  • `*args (verify: confirm completion in repo)
  • *kwargs`) (verify: confirm completion in repo)
  • Define scope for: add assertions that invoke is called exactly once (verify: confirm completion in repo)
  • Implement focused slice for: add assertions that invoke is called exactly once (verify: confirm completion in repo)
  • Validate focused slice for: add assertions that invoke is called exactly once (verify: confirm completion in repo)
  • Define scope for: that invoke.call_args.kwargs['quality_context'] is sentinel. (verify: confirm completion in repo)
  • Implement focused slice for: that invoke.call_args.kwargs['quality_context'] is sentinel. (verify: confirm completion in repo)
  • Validate focused slice for: that invoke.call_args.kwargs['quality_context'] is sentinel. (verify: confirm completion in repo)
• Review test-suite imports and add any missing runtime dependencies to requirements.txt, pinning langchain-community and requests with exact == versions and adding any other required packages with exact pins where feasible.
  • Review test-suite imports (verify: confirm completion in repo) add any missing runtime dependencies to requirements.txt (verify: dependencies updated) pinning langchain-community (verify: dependencies updated)
  • requests with exact == versions (verify: dependencies updated)
  • Define scope for: requests with adding any other required packages with exact pins where feasible. (verify: dependencies updated)
  • Implement focused slice for: requests with adding any other required packages with exact pins where feasible. (verify: dependencies updated)
  • Validate focused slice for: requests with adding any other required packages with exact pins where feasible. (verify: dependencies updated)

Acceptance criteria

• tests/test_structured_output.py contains a single parameterized test case over max_repair_attempts values [0, 1, 2, 10] (e.g., via pytest.mark.parametrize) and the test asserts the effective value used internally by capturing the argument passed to the repair-loop invocation (spy/mock on the repair-loop callsite, not by directly calling internal helper functions).
• For each input value in [0, 1, 2, 10], the structured-output test asserts that the captured repair-loop argument equals the expected effective value according to the production rule (either unchanged or clamped), and the expected mapping is explicitly encoded in the test (e.g., an expected_effective parameter) rather than inferred at runtime.
• The structured-output test includes an inline comment adjacent to the expectation that states the production rule for max_repair_attempts (e.g., “value is clamped to X” or “value is not clamped; forwarded as-is”), so that changing production behavior requires updating the comment and expected values together.
• tests/test_fallback_chain_provider.py constructs a FallbackChainProvider using at least two distinct underlying provider instances/mocks and invokes analyze_completion(...) exactly once with a unique sentinel = object() passed as quality_context.
• In the strengthened fallback-chain test, the selected/active underlying provider method (the one expected to handle the call) is asserted to have been called exactly once, and all other underlying provider methods are asserted not to have been called (call count == 0).
• The fallback-chain test verifies quality_context forwarding by identity by inspecting both call_args.args and call_args.kwargs, and includes an explicit assertion call_args.kwargs['quality_context'] is sentinel when the kwarg is present.
• In tests/test_anthropic_provider.py, DummyClient.invoke is defined with a signature that can accept the provider call pattern (must accept *args and **kwargs), so the test does not fail due to TypeError from argument mismatch.
• The anthropic-provider test asserts DummyClient.invoke is called exactly once during the operation under test (e.g., invoke.assert_called_once()), not merely that it was called.
• The anthropic-provider test passes a sentinel = object() as quality_context and asserts identity forwarding via DummyClient.invoke.call_args.kwargs['quality_context'] is sentinel.
• requirements.txt contains exact version pins (using ==) for both langchain-community and requests (no ranges like >= or unpinned entries for these two packages).
• Any additional packages required to import all modules exercised by the test suite are added to requirements.txt with exact == pins where feasible, and running python -m pytest -q in a fresh environment created from requirements.txt completes without ModuleNotFoundError.

[stranske-keepalive]

🤖 Keepalive Loop Status

PR #1392 | Agent: Codex | Iteration 0/5

Current State

Metric	Value
Iteration progress	[----------] 0/5
Action	wait (missing-agent-label)
Disposition	skipped (transient)
Gate	success
Tasks	15/54 complete
Timeout	45 min (default)
Timeout usage	3m elapsed (7%, 42m remaining)
Keepalive	❌ disabled
Autofix	❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |