Skip to content

fix: agents-weekly-metrics uses env vars not CLI args#134

Merged
stranske merged 1 commit intomainfrom
fix/weekly-metrics-env-vars
Dec 25, 2025
Merged

fix: agents-weekly-metrics uses env vars not CLI args#134
stranske merged 1 commit intomainfrom
fix/weekly-metrics-env-vars

Conversation

@stranske
Copy link
Copy Markdown
Owner

@stranske stranske commented Dec 25, 2025

The aggregate_agent_metrics.py script uses environment variables (METRICS_DIR, OUTPUT_PATH), not CLI arguments. The workflow was calling it with --artifacts-dir and --output which don't exist.

Found while evaluating PR #104 (now closed as redundant).

Changes

  • Changed workflow step from CLI args to env vars

Testing

  • Local validation passes
  • Script correctly reads METRICS_DIR and OUTPUT_PATH from environment

Automated Status Summary

Scope

  • Scope section missing from source issue.

Tasks

  • Tasks section missing from source issue.

Acceptance criteria

  • Acceptance criteria section missing from source issue.

Head SHA: e64a323
Latest Runs: ✅ success — Gate
Required: gate: ✅ success

Workflow / Job Result Logs
Agents PR meta manager ❔ in progress View run
CI Autofix Loop ✅ success View run
Copilot code review ✅ success View run
Gate ✅ success View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ✅ success View run
Health 45 Agents Guard ✅ success View run
Health 50 Security Scan ✅ success View run
Maint 52 Validate Workflows ✅ success View run
PR 11 - Minimal invariant CI ✅ success View run
Selftest CI ✅ success View run

The aggregate_agent_metrics.py script uses environment variables
(METRICS_DIR, OUTPUT_PATH), not CLI arguments. The workflow was
calling it with --artifacts-dir and --output which don't exist.

Found while evaluating PR #104 (now closed as redundant).
Copilot AI review requested due to automatic review settings December 25, 2025 06:46
@stranske stranske temporarily deployed to agent-high-privilege December 25, 2025 06:46 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the agents-weekly-metrics workflow where the aggregate_agent_metrics.py script was being invoked with CLI arguments (--artifacts-dir and --output) that don't exist. The script actually reads configuration from environment variables (METRICS_DIR and OUTPUT_PATH).

Key changes:

  • Replaced CLI argument invocation with environment variable configuration for the metrics aggregation script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 040992f
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / Enforce agents workflow protections
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 77.97%
Baseline 0.00%
Delta +77.97%
Minimum 70.00%
Status ✅ Pass

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #134 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Gate success
Tasks 0/2 complete
Keepalive ❌ disabled
Autofix ❌ disabled

⚠️ Failure Tracking

| Consecutive failures | 1/3 |
| Reason | missing-agent-label |

@stranske stranske merged commit a2efd2c into main Dec 25, 2025
148 checks passed
@stranske stranske deleted the fix/weekly-metrics-env-vars branch December 25, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants