Skip to content

feat(verifier): add acceptance_count output for metrics #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 3 commits into from
Dec 25, 2025
Merged

feat(verifier): add acceptance_count output for metrics #133

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a7bb65
feat(verifier): add acceptance_count output for metrics
stranske Dec 25, 2025
2414ae6
Update .github/scripts/agents_verifier_context.js
stranske Dec 25, 2025
20d2eff
Merge branch 'main' into fix/verifier-acceptance-count
stranske Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions .github/scripts/agents_verifier_context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
const fs = require('fs');
const path = require('path');

const { extractScopeTasksAcceptanceSections } = require('./issue_scope_parser.js');
const {
extractScopeTasksAcceptanceSections,
parseScopeTasksAcceptanceSections,
} = require('./issue_scope_parser.js');

const DEFAULT_BRANCH = process.env.DEFAULT_BRANCH || 'main';

Expand All @@ -17,6 +20,21 @@ function uniqueNumbers(values) {
);
}

/**
* Count markdown checkboxes within acceptance-criteria content.
*
* This helper is intended to be used on the "Acceptance criteria"
* section(s) extracted from issues or pull requests, not on arbitrary
* markdown content.
*
* @param {string} acceptanceContent - The acceptance-criteria text to scan.
* @returns {number} The number of checkbox items found.
*/
function countCheckboxes(acceptanceContent) {
const matches = String(acceptanceContent || '').match(/(^|\n)\s*[-*]\s+\[[ xX]\]/gi);
return matches ? matches.length : 0;
}

function isForkPullRequest(pr) {
const headRepo = pr?.head?.repo;
const baseRepo = pr?.base?.repo;
Expand Down Expand Up @@ -132,6 +150,7 @@ async function buildVerifierContext({ github, context, core }) {
core?.setOutput?.('pr_html_url', '');
core?.setOutput?.('target_sha', context.sha || '');
core?.setOutput?.('context_path', '');
core?.setOutput?.('acceptance_count', '0');
return { shouldRun: false, reason: resolveReason || 'No pull request detected.' };
}

Expand All @@ -147,6 +166,7 @@ async function buildVerifierContext({ github, context, core }) {
core?.setOutput?.('pr_html_url', pr.html_url || '');
core?.setOutput?.('target_sha', pr.merge_commit_sha || pr.head?.sha || context.sha || '');
core?.setOutput?.('context_path', '');
core?.setOutput?.('acceptance_count', '0');
return { shouldRun: false, reason: skipReason };
}

Expand All @@ -163,6 +183,7 @@ async function buildVerifierContext({ github, context, core }) {
core?.setOutput?.('pr_html_url', pull.html_url || '');
core?.setOutput?.('target_sha', pull.merge_commit_sha || pull.head?.sha || context.sha || '');
core?.setOutput?.('context_path', '');
core?.setOutput?.('acceptance_count', '0');
return { shouldRun: false, reason: skipReason };
}

Expand All @@ -176,6 +197,10 @@ async function buildVerifierContext({ github, context, core }) {
const issueNumbers = uniqueNumbers(closingIssues.map((issue) => issue.number));

const sections = [];
let acceptanceCount = 0;

const pullSections = parseScopeTasksAcceptanceSections(pull.body || '');
acceptanceCount += countCheckboxes(pullSections.acceptance);
const prSections = extractScopeTasksAcceptanceSections(pull.body || '', {
includePlaceholders: true,
});
Expand All @@ -188,6 +213,8 @@ async function buildVerifierContext({ github, context, core }) {
);

for (const issue of closingIssues) {
const issueSectionsParsed = parseScopeTasksAcceptanceSections(issue.body || '');
acceptanceCount += countCheckboxes(issueSectionsParsed.acceptance);
const issueSections = extractScopeTasksAcceptanceSections(issue.body || '', {
includePlaceholders: true,
});
Expand Down Expand Up @@ -230,8 +257,9 @@ async function buildVerifierContext({ github, context, core }) {
core?.setOutput?.('pr_html_url', pull.html_url || '');
core?.setOutput?.('target_sha', targetSha);
core?.setOutput?.('context_path', contextPath);
core?.setOutput?.('acceptance_count', String(acceptanceCount));

return { shouldRun: true, markdown, contextPath, issueNumbers, targetSha };
return { shouldRun: true, markdown, contextPath, issueNumbers, targetSha, acceptanceCount };
}

module.exports = {
Expand Down
Loading