Codex/issue 123

.github/scripts/__tests__/agents-pr-meta-update-body.test.js

@@ -9,6 +9,8 @@ const {
   ensureChecklist,
   extractBlock,
   fetchConnectorCheckboxStates,
+  buildStatusBlock,
+  resolveAgentType,
 } = require('../agents_pr_meta_update_body.js');
 
 test('parseCheckboxStates extracts checked items from a checkbox list', () => {
@@ -318,3 +320,96 @@ test('fetchConnectorCheckboxStates handles comments with null user', async () =>
   assert.strictEqual(states.size, 1);
   assert.strictEqual(states.get('valid task'), true);
 });
+
+test('resolveAgentType prefers explicit inputs over labels', () => {
+  const agentType = resolveAgentType({
+    inputs: { agent_type: 'codex' },
+    env: { AGENT_TYPE: 'claude' },
+    pr: { labels: [{ name: 'agent:gemini' }] },
+  });
+
+  assert.strictEqual(agentType, 'codex');
+});
+
+test('resolveAgentType falls back to agent label when inputs are missing', () => {
+  const agentType = resolveAgentType({
+    inputs: {},
+    env: {},
+    pr: { labels: [{ name: 'priority:high' }, { name: 'agent:codex' }] },
+  });
+
+  assert.strictEqual(agentType, 'codex');
+});
+
+test('resolveAgentType returns empty string when no agent source is available', () => {
+  const agentType = resolveAgentType({
+    inputs: {},
+    env: {},
+    pr: { labels: [{ name: 'needs-human' }] },
+  });
+
+  assert.strictEqual(agentType, '');
+});
+
+test('buildStatusBlock hides workflow details for CLI agents', () => {
+  const workflowRuns = new Map([
+    ['gate', {
+      name: 'Gate',
+      created_at: '2024-01-02T00:00:00Z',
+      status: 'completed',
+      conclusion: 'success',
+      html_url: 'https://example.com/run',
+    }],
+  ]);
+
+  const output = buildStatusBlock({
+    scope: '- [ ] Scope item',
+    tasks: '- [ ] Task item',
+    acceptance: '- [ ] Acceptance item',
+    headSha: 'abc123',
+    workflowRuns,
+    requiredChecks: ['gate'],
+    existingBody: '',
+    connectorStates: new Map(),
+    core: null,
+    agentType: 'codex',
+  });
+
+  assert.ok(output.includes('## Automated Status Summary'));
+  assert.ok(output.includes('#### Scope'));
+  assert.ok(output.includes('#### Tasks'));
+  assert.ok(output.includes('#### Acceptance criteria'));
+  assert.ok(!output.includes('**Head SHA:**'));
+  assert.ok(!output.includes('**Latest Runs:**'));
+  assert.ok(!output.includes('**Required:**'));
+  assert.ok(!output.includes('| Workflow / Job |'));
+});
+
+test('buildStatusBlock includes workflow details for non-CLI agents', () => {
+  const workflowRuns = new Map([
+    ['gate', {
+      name: 'Gate',
+      created_at: '2024-01-02T00:00:00Z',
+      status: 'completed',
+      conclusion: 'success',
+      html_url: 'https://example.com/run',
+    }],
+  ]);
+
+  const output = buildStatusBlock({
+    scope: '- [ ] Scope item',
+    tasks: '- [ ] Task item',
+    acceptance: '- [ ] Acceptance item',
+    headSha: 'abc123',
+    workflowRuns,
+    requiredChecks: ['gate'],
+    existingBody: '',
+    connectorStates: new Map(),
+    core: null,
+    agentType: '',
+  });
+
+  assert.ok(output.includes('**Head SHA:** abc123'));
+  assert.ok(output.includes('**Required:** gate: ✅ success'));
+  assert.ok(output.includes('| Workflow / Job |'));
+});

.github/scripts/__tests__/comment-dedupe.test.js

@@ -176,3 +176,38 @@ test('upsertAnchoredComment reads body from file and infers PR from anchor', asy
 
   fs.unlinkSync(commentPath);
 });
+
+test('upsertAnchoredComment skips gate summary when agent label is present', async () => {
+  const actions = [];
+  const github = {
+    paginate: async (fn) => {
+      if (fn === github.rest.issues.listLabelsOnIssue) {
+        return [{ name: 'agent:codex' }];
+      }
+      throw new Error('listComments should not be called');
+    },
+    rest: {
+      issues: {
+        listLabelsOnIssue: async () => ({ data: [] }),
+        listComments: async () => ({ data: [] }),
+        updateComment: async () => actions.push('update'),
+        createComment: async () => {
+          actions.push('create');
+          return { data: { id: 1 } };
+        },
+      },
+    },
+  };
+
+  await upsertAnchoredComment({
+    github,
+    context: { repo: { owner: 'octo', repo: 'demo' } },
+    core: null,
+    prNumber: 12,
+    body: 'Gate summary\n<!-- gate-summary: pr=12 head=abc -->',
+    anchorPattern: /<!--\s*gate-summary:([^>]*)-->/i,
+    fallbackMarker: '<!-- gate-summary:',
+  });
+
+  assert.deepEqual(actions, []);
+});