-
Notifications
You must be signed in to change notification settings - Fork 1
Fix/setup api client coverage gaps #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
73525e1
docs: add setup-api-client coverage audit spreadsheet
stranske 626e159
fix: add setup-api-client to all jobs making GitHub API calls
stranske 597b098
docs: update audit spreadsheet with PR#1189
stranske ade45b2
fix: address review comment - use correct checkout path per job
stranske File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -393,8 +393,17 @@ jobs: | |||||||||||
| with: | ||||||||||||
| sparse-checkout: | | ||||||||||||
| .github/scripts/github-api-with-retry.js | ||||||||||||
| .github/actions/setup-api-client | ||||||||||||
| .github/scripts/github-rate-limited-wrapper.js | ||||||||||||
| .github/scripts/token_load_balancer.js | ||||||||||||
| sparse-checkout-cone-mode: false | ||||||||||||
|
|
||||||||||||
| - name: Setup API client | ||||||||||||
| uses: ./.github/actions/setup-api-client | ||||||||||||
| with: | ||||||||||||
| secrets: ${{ toJSON(secrets) }} | ||||||||||||
| github_token: ${{ github.token }} | ||||||||||||
|
||||||||||||
| github_token: ${{ github.token }} | |
| github_token: ${{ github.token }} | |
| service_bot_pat: ${{ secrets.service_bot_pat }} | |
| gh_app_id: ${{ secrets.gh_app_id }} | |
| gh_app_private_key: ${{ secrets.gh_app_private_key }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| workflow,job,github_script_count,has_setup_api_client,coverage_status,fix_status,fix_pr,fix_date,notes | ||
| agents-autofix-loop.yml,metrics,1,Yes,Covered,Fixed,PR#1189,2026-02-02,Added sparse-checkout deps + setup-api-client step | ||
| agents-bot-comment-handler.yml,cleanup,1,Yes,Covered,Fixed,PR#1189,2026-02-02,Added sparse-checkout deps + setup-api-client step | ||
| reusable-10-ci-python.yml,logs_summary,1,Yes,Covered,Fixed,PR#1189,2026-02-02,Added checkout + setup-api-client (was missing checkout) | ||
| reusable-16-agents.yml,preflight,3,Yes,Covered,Fixed,PR#1189,2026-02-02,Added sparse-checkout deps + setup-api-client step | ||
| reusable-16-agents.yml,verify_issue_summary,2,No,FALSE_POSITIVE,N/A,,,Uses github-script but only writes to core.summary - no API calls | ||
| reusable-20-pr-meta.yml,keepalive_dispatch,1,Yes,Covered,Existing,PR#1183,,Already had setup-api-client via consumer checkout | ||
| reusable-20-pr-meta.yml,keepalive_orchestrator,1,Yes,Covered,Fixed,PR#1189,2026-02-02,Added workflows-lib sparse-checkout + setup-api-client | ||
| reusable-20-pr-meta.yml,keepalive_from_gate,1,Yes,Covered,Fixed,PR#1189,2026-02-02,Added workflows-lib sparse-checkout + setup-api-client | ||
| reusable-20-pr-meta.yml,pr_body_update,2,Yes,Covered,Fixed,PR#1189,2026-02-02,Added workflows-lib sparse-checkout + setup-api-client | ||
| reusable-bot-comment-handler.yml,dispatch,1,Yes,Covered,Fixed,PR#1189,2026-02-02,Added sparse-checkout deps + setup-api-client step |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflow_calldefinesservice_bot_patas a lower-case secret name, butsetup-api-client’stoJSON(secrets)parsing only extractsSERVICE_BOT_PAT(upper-case). As a result this step won’t export the service bot token unless you also pass the action’sservice_bot_patinput (or update parsing to handle lower-case keys).