Skip to content

feat: standardize token export for retry helpers (#1142)#1142

Merged
stranske merged 3 commits intomainfrom
fix/verify-compare-partial
Jan 28, 2026
Merged

feat: standardize token export for retry helpers (#1142)#1142
stranske merged 3 commits intomainfrom
fix/verify-compare-partial

Conversation

@stranske
Copy link
Copy Markdown
Owner

@stranske stranske commented Jan 28, 2026

Source: Issue #1142

Automated Status Summary

Scope

After merging PR #103 (multi-agent routing infrastructure), we need to:

Context for Agent

Design Decisions & Constraints

Related Issues/PRs

References

Blockers & Dependencies

Tasks

  • 1. Validate the CLI agent pipeline works end-to-end with the new task-focused prompts
  • 2. Add GITHUB_STEP_SUMMARY output so iteration results are visible in the Actions UI
  • 3. Streamline the Automated Status Summary to reduce clutter when using CLI agents
  • 4. Clean up comment patterns to avoid a mix of old UI-agent and new CLI-agent comments

Acceptance criteria

  • CLI agent receives explicit tasks in prompt and works on them
  • Iteration results visible in Actions workflow run summary
  • PR body shows checkboxes but not workflow clutter when using CLI agents
  • UI Codex path (no agent label) continues to show full status summary
  • CLI agent PRs have ≤3 bot comments total (summary, one per iteration update) instead of 10+
  • State tracking is consolidated in the summary comment, not scattered
  • Head SHA: 85c6d97
  • Latest Runs: ✅ success — Gate
  • Required: gate: ✅ success
  • | Workflow / Job | Result | Logs |
  • |----------------|--------|------|
  • | Agents PR meta manager | ❔ in progress | View run |
  • | CI Autofix Loop | ✅ success | View run |
  • | Gate | ✅ success | View run |
  • | Health 40 Sweep | ✅ success | View run |
  • | Health 44 Gate Branch Protection | ✅ success | View run |
  • | Health 45 Agents Guard | ✅ success | View run |
  • | Health 50 Security Scan | ✅ success | View run |
  • | Health 72 Template Sync | ✅ success | View run |
  • | Health 73 Template Completeness | ✅ success | View run |
  • | Keepalive E2E | ❔ startup failure | View run |
  • | Maint 52 Validate Workflows | ✅ success | View run |
  • | PR 11 - Minimal invariant CI | ✅ success | View run |
  • | Selftest CI | ✅ success | View run |
  • | Validate Sync Manifest | ✅ success | View run |

Head SHA: 85c6d97
Latest Runs: ✅ success — Gate
Required: gate: ✅ success

Workflow / Job Result Logs
Agents PR meta manager ❔ in progress View run
CI Autofix Loop ✅ success View run
Gate ✅ success View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ✅ success View run
Health 45 Agents Guard ✅ success View run
Health 50 Security Scan ✅ success View run
Health 72 Template Sync ✅ success View run
Health 73 Template Completeness ✅ success View run
Keepalive E2E ❔ startup failure View run
Maint 52 Validate Workflows ✅ success View run
PR 11 - Minimal invariant CI ✅ success View run
Selftest CI ✅ success View run
Validate Sync Manifest ✅ success View run

Copilot AI review requested due to automatic review settings January 28, 2026 17:55
@agents-workflows-bot
Copy link
Copy Markdown
Contributor

⚠️ Action Required: Unable to determine source issue for PR #1142. The PR title, branch name, or body must contain the issue number (e.g. #123, branch: issue-123, or the hidden marker ).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 28, 2026

Automated Status Summary

Head SHA: eddf5c1
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / Enforce agents workflow protections
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 93.12%
Baseline 85.00%
Delta +8.12%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
src/cli_parser.py 81.8% 4
src/percentile_calculator.py 95.0% 1
src/aggregator.py 95.0% 2
src/__init__.py 100.0% 0
src/ndjson_parser.py 100.0% 0

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

After merging PR #103 (multi-agent routing infrastructure), we need to:

Context for Agent

Design Decisions & Constraints

Related Issues/PRs

References

Blockers & Dependencies

Tasks

  • 1. Validate the CLI agent pipeline works end-to-end with the new task-focused prompts
  • 2. Add GITHUB_STEP_SUMMARY output so iteration results are visible in the Actions UI
  • 3. Streamline the Automated Status Summary to reduce clutter when using CLI agents
  • 4. Clean up comment patterns to avoid a mix of old UI-agent and new CLI-agent comments

Acceptance criteria

  • CLI agent receives explicit tasks in prompt and works on them
  • Iteration results visible in Actions workflow run summary
  • PR body shows checkboxes but not workflow clutter when using CLI agents
  • UI Codex path (no agent label) continues to show full status summary
  • CLI agent PRs have ≤3 bot comments total (summary, one per iteration update) instead of 10+
  • State tracking is consolidated in the summary comment, not scattered
  • [ ]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 28, 2026

🤖 Keepalive Loop Status

PR #1142 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Disposition skipped (transient)
Gate success
Tasks 0/29 complete
Timeout 45 min (default)
Timeout usage 2m elapsed (5%, 43m remaining)
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 538d5a4eca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request standardizes token export configuration for retry helpers across all workflows by introducing a reusable composite action. It extends the token load balancer to support dynamic configuration through TOKEN_ROTATION_JSON and TOKEN_ROTATION_ENV_KEYS, and improves the rate-limited wrapper to properly handle paginate operations with token switching.

Changes:

  • Introduces .github/actions/export-load-balancer-tokens composite action to centralize token export logic
  • Extends token_load_balancer.js with support for dynamic token rotation via JSON config and environment key lists
  • Fixes github-rate-limited-wrapper.js paginate/iterator methods to properly resolve wrapped methods for token switching
  • Updates 40+ workflow files to use the new composite action consistently

Reviewed changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
.github/actions/export-load-balancer-tokens/action.yml New composite action that exports token secrets to environment variables
.github/scripts/token_load_balancer.js Added parsing functions and support for TOKEN_ROTATION_JSON and TOKEN_ROTATION_ENV_KEYS
.github/scripts/github-rate-limited-wrapper.js Fixed paginate wrapper to use method metadata for proper token rotation
.github/scripts/github-api-with-retry.js Added new token rotation config keys to collected secrets
.github/scripts/README.md Documented the new composite action usage and dynamic token configuration
.github/scripts/API_CALL_PATTERN.md Added example usage of the composite action
Multiple workflow files (40+) Integrated the composite action and updated sparse-checkout paths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stranske stranske force-pushed the fix/verify-compare-partial branch from 538d5a4 to 25d9409 Compare January 28, 2026 18:04
@stranske stranske changed the title feat: standardize token export for retry helpers feat: standardize token export for retry helpers (#1142) Jan 28, 2026
@stranske stranske temporarily deployed to agent-high-privilege January 28, 2026 18:04 — with GitHub Actions Inactive
@stranske stranske temporarily deployed to agent-high-privilege January 28, 2026 18:13 — with GitHub Actions Inactive
@stranske stranske force-pushed the fix/verify-compare-partial branch from 25d9409 to 6e0dc8d Compare January 28, 2026 18:33
@stranske
Copy link
Copy Markdown
Owner Author

Responding to inline bot comments:\n\n- #1142 (comment): updated collectTokenSecrets to include keys from TOKEN_ROTATION_ENV_KEYS/TOKEN_ROTATION_KEYS and mirrored in templates.\n- #1142 (comment): fixed the indentation in health-70-validate-sync-manifest.yml.\n- #1142 (comment): moved export step to the top of maint-69-sync-labels.yml and removed the stray trailing step.\n- #1142 (comment): moved export step to the top of health-40-repo-selfcheck.yml and removed the stray trailing step.\n- #1142 (comment): fixed indentation in github-rate-limited-wrapper.js (main + template).\n- #1142 (comment): hardened export_var with in the composite action (main + template).\n- #1142 (comment): adjusted template maint-coverage-guard.yml so export runs after the sparse checkout and removed the earlier redundant export.

@stranske stranske temporarily deployed to agent-high-privilege January 28, 2026 19:18 — with GitHub Actions Inactive
@stranske stranske force-pushed the fix/verify-compare-partial branch from 30c26e3 to d2bab94 Compare January 28, 2026 19:56
@stranske stranske temporarily deployed to agent-high-privilege January 28, 2026 19:56 — with GitHub Actions Inactive
@stranske stranske temporarily deployed to agent-high-privilege January 28, 2026 20:05 — with GitHub Actions Inactive
@stranske stranske merged commit 8123954 into main Jan 28, 2026
200 checks passed
@stranske stranske deleted the fix/verify-compare-partial branch January 28, 2026 20:08
stranske added a commit that referenced this pull request Jan 29, 2026
* feat: standardize token export for retry helpers (#1142)

* fix: normalize health-70 workflow indentation (#1142)

* fix: allow token secret names in actionlint (#1142)

* fix: write multiline tokens to GITHUB_ENV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants