feat: standardize token export for retry helpers (#1142)#1142
Conversation
Automated Status SummaryHead SHA: eddf5c1
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeAfter merging PR #103 (multi-agent routing infrastructure), we need to: Context for AgentDesign Decisions & Constraints
Related Issues/PRsReferences
Blockers & Dependencies
Tasks
Acceptance criteria
|
🤖 Keepalive Loop StatusPR #1142 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 538d5a4eca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This pull request standardizes token export configuration for retry helpers across all workflows by introducing a reusable composite action. It extends the token load balancer to support dynamic configuration through TOKEN_ROTATION_JSON and TOKEN_ROTATION_ENV_KEYS, and improves the rate-limited wrapper to properly handle paginate operations with token switching.
Changes:
- Introduces
.github/actions/export-load-balancer-tokenscomposite action to centralize token export logic - Extends
token_load_balancer.jswith support for dynamic token rotation via JSON config and environment key lists - Fixes
github-rate-limited-wrapper.jspaginate/iterator methods to properly resolve wrapped methods for token switching - Updates 40+ workflow files to use the new composite action consistently
Reviewed changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
.github/actions/export-load-balancer-tokens/action.yml |
New composite action that exports token secrets to environment variables |
.github/scripts/token_load_balancer.js |
Added parsing functions and support for TOKEN_ROTATION_JSON and TOKEN_ROTATION_ENV_KEYS |
.github/scripts/github-rate-limited-wrapper.js |
Fixed paginate wrapper to use method metadata for proper token rotation |
.github/scripts/github-api-with-retry.js |
Added new token rotation config keys to collected secrets |
.github/scripts/README.md |
Documented the new composite action usage and dynamic token configuration |
.github/scripts/API_CALL_PATTERN.md |
Added example usage of the composite action |
| Multiple workflow files (40+) | Integrated the composite action and updated sparse-checkout paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
templates/consumer-repo/.github/workflows/maint-coverage-guard.yml
Outdated
Show resolved
Hide resolved
538d5a4 to
25d9409
Compare
25d9409 to
6e0dc8d
Compare
|
Responding to inline bot comments:\n\n- #1142 (comment): updated collectTokenSecrets to include keys from TOKEN_ROTATION_ENV_KEYS/TOKEN_ROTATION_KEYS and mirrored in templates.\n- #1142 (comment): fixed the indentation in health-70-validate-sync-manifest.yml.\n- #1142 (comment): moved export step to the top of maint-69-sync-labels.yml and removed the stray trailing step.\n- #1142 (comment): moved export step to the top of health-40-repo-selfcheck.yml and removed the stray trailing step.\n- #1142 (comment): fixed indentation in github-rate-limited-wrapper.js (main + template).\n- #1142 (comment): hardened export_var with in the composite action (main + template).\n- #1142 (comment): adjusted template maint-coverage-guard.yml so export runs after the sparse checkout and removed the earlier redundant export. |
30c26e3 to
d2bab94
Compare
Automated Status Summary
Scope
After merging PR #103 (multi-agent routing infrastructure), we need to:
Context for Agent
Design Decisions & Constraints
<!-- keepalive-loop-summary -->| github-actions[bot] | NEW: CLI agent iteration tracking | ✅ Keep for CLI agents |<!-- keepalive-state:v1 -->| agents-workflows-bot[bot] | State tracking |<!-- keepalive-round: N -->| stranske | OLD: Instruction comment | ❌ CLI agents dont need this |agent:*label), we should have exactly one updating comment (<!-- keepalive-loop-summary -->) instead of accumulating 10+ comments per PR.Related Issues/PRs
References
Blockers & Dependencies
Tasks
GITHUB_STEP_SUMMARYoutput so iteration results are visible in the Actions UIAcceptance criteria
Head SHA: 85c6d97
Latest Runs: ✅ success — Gate
Required: gate: ✅ success