Skip to content

fix(keepalive): use full repo path for reusable workflow #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 1 commit into from
Dec 24, 2025
Merged

fix(keepalive): use full repo path for reusable workflow #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/agents-keepalive-loop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ jobs:
name: Keepalive next task
needs:
- evaluate
uses: ./.github/workflows/reusable-codex-run.yml
uses: stranske/Workflows/.github/workflows/reusable-codex-run.yml@main

Copilot AI Dec 24, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change references a reusable workflow from the same repository using the full repository path instead of the local relative path. This creates an inconsistency with other workflows in the codebase.

The agents-autofix-loop.yml workflow (line 261) uses the local path ./.github/workflows/reusable-codex-run.yml to call the same reusable workflow. All other reusable workflow calls in this repository use the local path pattern (e.g., reusable-10-ci-python.yml, reusable-70-orchestrator-init.yml, reusable-agents-issue-bridge.yml).

Using the full repository path for a local reusable workflow introduces several issues:

  1. It creates unnecessary external dependency on the repository's availability
  2. It bypasses testing of local changes to the reusable workflow
  3. It creates maintenance confusion about which workflows are external vs internal
  4. It may reference the wrong branch (main) instead of the current working branch during testing

Consider using the standard local path pattern ./.github/workflows/reusable-codex-run.yml for consistency with the rest of the codebase.

Suggested change
uses: stranske/Workflows/.github/workflows/reusable-codex-run.yml@main
uses: ./.github/workflows/reusable-codex-run.yml

Copilot uses AI. Check for mistakes.
secrets:
CODEX_AUTH_JSON: ${{ secrets.CODEX_AUTH_JSON }}
WORKFLOWS_APP_ID: ${{ secrets.WORKFLOWS_APP_ID }}
Expand Down
Loading