Avoid canceling concurrent codex runs (#1103)#1103
Conversation
stranske
temporarily deployed
to
agent-high-privilege
GitHub Actions
Inactive
Automated Status SummaryHead SHA: 46fba70
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
There was a problem hiding this comment.
Pull request overview
This PR modifies the concurrency configuration in the reusable Codex workflow to allow different Codex modes (keepalive, autofix, verifier) to run concurrently on the same pull request without canceling each other.
Changes:
- Updated concurrency group to include the mode parameter, allowing different modes to run in parallel
- Changed cancel-in-progress from true to false to prevent cancellation of concurrent runs
- Added pr_number as the primary identifier with github.ref as fallback for cases where pr_number is not provided
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🤖 Keepalive Loop StatusPR #1103 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71898181e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| group: codex-${{ inputs.mode }}-${{ inputs.pr_number || github.ref }} |
There was a problem hiding this comment.
The new concurrency group includes inputs.mode, so keepalive and autofix runs for the same PR no longer share a group. Both .github/workflows/agents-keepalive-loop.yml and .github/workflows/agents-autofix-loop.yml call this reusable workflow with the same pr_number/pr_ref but different mode values, which now allows simultaneous runs that both push to the same branch. That increases the chance of push rejections or conflicting rebases in the commit step, causing failed runs or interleaved commits. Consider keying the group only by PR/target branch (or pr_ref) so different modes still serialize on the same branch.
Useful? React with 👍 / 👎.
❌ Sync Manifest Validation FailedThis PR modifies files that should be synced to consumer repos, but the sync manifest is incomplete. Required action: Update Why this mattersFiles not declared in the manifest won't be synced to consumer repos (Template, Manager-Database, trip-planner, Travel-Plan-Permission), causing features to silently not work in those repos. How to fix
See the workflow logs for specific files that need to be added. |
stranske
temporarily deployed
to
agent-high-privilege
GitHub Actions
Inactive
stranske
temporarily deployed
to
agent-high-privilege
GitHub Actions
Inactive
stranske
temporarily deployed
to
agent-high-privilege
GitHub Actions
Inactive
github-actions
bot
added
the
autofix
stranske
changed the title
|
Status | ✅ no new diagnostics |
Automated Status Summary
Scope
After merging PR #103 (multi-agent routing infrastructure), we need to:
Context for Agent
Design Decisions & Constraints
<!-- keepalive-loop-summary -->| github-actions[bot] | NEW: CLI agent iteration tracking | ✅ Keep for CLI agents |<!-- keepalive-state:v1 -->| agents-workflows-bot[bot] | State tracking |<!-- keepalive-round: N -->| stranske | OLD: Instruction comment | ❌ CLI agents dont need this |agent:*label), we should have exactly one updating comment (<!-- keepalive-loop-summary -->) instead of accumulating 10+ comments per PR.excluded:with a reasonRelated Issues/PRs
References
Blockers & Dependencies
Tasks
GITHUB_STEP_SUMMARYoutput so iteration results are visible in the Actions UIAcceptance criteria
Head SHA: e0a34c2
Latest Runs: ❌ failure — Gate
Required: gate: ❌ failure