Skip to content

fix(keepalive): use always() to ensure reusable workflow job is created #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 1 commit into from
Dec 24, 2025
Merged

fix(keepalive): use always() to ensure reusable workflow job is created #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/agents-keepalive-loop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ jobs:
name: Keepalive next task
needs:
- evaluate
if: needs.evaluate.outputs.action == 'run'
if: ${{ always() && needs.evaluate.result == 'success' && needs.evaluate.outputs.action == 'run' }}
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ${{ }} expression wrapper is redundant in the if: condition since GitHub Actions already evaluates expressions in this context. For consistency with other conditions in this workflow (lines 126 and 174), consider removing the wrapper to use: if: always() && needs.evaluate.result == 'success' && needs.evaluate.outputs.action == 'run'

Suggested change
if: ${{ always() && needs.evaluate.result == 'success' && needs.evaluate.outputs.action == 'run' }}
if: always() && needs.evaluate.result == 'success' && needs.evaluate.outputs.action == 'run'

Copilot uses AI. Check for mistakes.
uses: ./.github/workflows/reusable-codex-run.yml
secrets:
CODEX_AUTH_JSON: ${{ secrets.CODEX_AUTH_JSON }}
Expand Down
Loading