Skip to content

fix(keepalive): remove preflight dependency from run-codex job #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 2 commits into from
Dec 24, 2025
Merged

fix(keepalive): remove preflight dependency from run-codex job #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf17ea8
fix(keepalive): remove preflight dependency from run-codex job
stranske Dec 24, 2025
ea11578
fix(autofix): change actions permission from read to write
stranske Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/agents-autofix-loop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
permissions:
contents: write
pull-requests: write
actions: read
actions: write

concurrency:
group: agents-autofix-loop-${{ github.event.workflow_run.pull_requests[0].number || github.run_id }}
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/agents-keepalive-loop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,7 @@ jobs:
name: Keepalive next task
needs:
- evaluate
- preflight
if: needs.evaluate.outputs.action == 'run' && needs.preflight.outputs.secrets_ok == 'true'
if: needs.evaluate.outputs.action == 'run'
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a validation inconsistency to be aware of: the preflight job validates that either CODEX_AUTH_JSON or WORKFLOWS_APP_ID is present (line 142 in the full file), but the reusable workflow strictly requires CODEX_AUTH_JSON and will fail if it's missing (see reusable-codex-run.yml:198-201).

This means if only WORKFLOWS_APP_ID credentials are configured, the preflight job would pass, but run-codex will fail later with "CODEX_AUTH_JSON secret is not set or empty."

Since this change removes the preflight dependency, the job will now run and fail during execution rather than being skipped upfront. Consider either:

  1. Updating preflight validation logic to match the actual requirements (require CODEX_AUTH_JSON)
  2. Removing the preflight job entirely if it's no longer serving a useful purpose

Note: This is a pre-existing inconsistency that becomes more visible with this change, not a new issue introduced by this PR.

Copilot uses AI. Check for mistakes.
uses: ./.github/workflows/reusable-codex-run.yml
secrets:
CODEX_AUTH_JSON: ${{ secrets.CODEX_AUTH_JSON }}
Expand Down
Loading