fix(keepalive): pass secrets explicitly to reusable workflow#106
Merged
fix(keepalive): pass secrets explicitly to reusable workflow#106
Conversation
…e workflow The silent skip of the run-codex job was caused by secrets: inherit not properly passing secrets to the reusable workflow call. This changes to explicitly passing the required secrets, which matches how agents-autofix-loop.yml already does it.
Contributor
Automated Status SummaryHead SHA: 8246b35
Coverage Overview
Coverage Trend
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the run-codex job in the keepalive loop workflow was being silently skipped when action == 'run'. The issue occurred because secrets: inherit doesn't properly pass secrets in workflow_run event contexts.
- Changed from
secrets: inheritto explicitly passing three required secrets - Matches the pattern already used in
agents-autofix-loop.yml
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the keepalive loop determines
action == 'run', the Codex reusable workflow call was being silently skipped. This PR fixes it by explicitly passing secrets instead of usingsecrets: inherit.Problem
The
run-codexjob in agents-keepalive-loop.yml was usingsecrets: inheritto pass secrets to the reusable workflow. This caused the job to be silently skipped when the workflow_run event context did not properly inherit secrets.Evidence from workflow runs:
Solution
Changed from
secrets: inheritto explicitly listing each secret name that the reusable workflow needs. This matches the pattern used in agents-autofix-loop.yml.Fixes #79 (partial - Codex CLI integration)
Automated Status Summary
Scope
Tasks
Acceptance criteria
Head SHA: 11979b3
Latest Runs: ⏹️ cancelled — Gate
Required: gate: ⏹️ cancelled