fix(deps): update dependency coverage to v7.14.2 - #35
Conversation
📝 WalkthroughWalkthroughThe pinned Changescoverage Dev Dependency Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Workflow source neededPR #35 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely. Please do one of:
Once a valid source is present, this warning will not be reposted. |
🤖 Keepalive Loop StatusPR #35 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pyproject.toml (1)
37-40:⚠️ Potential issue | 🟠 MajorAdd
fail_under = 35to the[tool.coverage.report]section in pyproject.toml to match thecoverage-min: "35"setting in workflow files.The coding guidelines require coverage threshold settings to match between
pyproject.tomland workflow files. The.github/workflows/pr-00-gate.ymlfile specifiescoverage-min: "35", butpyproject.tomllacks the correspondingfail_undersetting in the[tool.coverage.report]section. Addfail_under = 35to align with the workflow configuration.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pyproject.toml` around lines 37 - 40, In the `[tool.coverage.report]` section of pyproject.toml, add the configuration `fail_under = 35` to match the coverage threshold specified in the workflow files. This setting should be added alongside the existing precision, show_missing, and skip_covered settings to ensure consistency between the local coverage configuration and the CI/CD workflow requirements.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@pyproject.toml`:
- Around line 37-40: In the `[tool.coverage.report]` section of pyproject.toml,
add the configuration `fail_under = 35` to match the coverage threshold
specified in the workflow files. This setting should be added alongside the
existing precision, show_missing, and skip_covered settings to ensure
consistency between the local coverage configuration and the CI/CD workflow
requirements.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ceeb1ca1-6a90-4df4-9f85-0029e4d6cb80
📒 Files selected for processing (1)
pyproject.toml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
stranske/Workflows(auto-detected)
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: Python CI / logs summary
🧰 Additional context used
📓 Path-based instructions (3)
pyproject.toml
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
pyproject.toml: For mypy type errors on modules with existing type issues, add overrides to pyproject.toml with ignore_errors = true instead of using exclude patterns
Use ignore_errors = true in mypy overrides instead of exclude patterns because exclude only prevents direct checking, not imports from other modules
Files:
pyproject.toml
{pyproject.toml,.github/workflows/**/*.{yml,yaml}}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Ensure coverage threshold settings match between pyproject.toml ([tool.coverage.report] fail_under) and workflow files (coverage-min setting)
Files:
pyproject.toml
{requirements*.txt,setup.py,pyproject.toml}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Pin jsonschema to compatible range jsonschema>=4.17.3,<4.23.0 due to breaking changes in version 4.23.0+ with referencing
Files:
pyproject.toml
🔀 Multi-repo context stranske/Workflows
Based on my exploration of the repository, I've identified relevant cross-repository context related to the coverage version update:
Findings
Repository: stranske/Workflows
Coverage JSON Usage [::stranske/Workflows::]
The project has significant coverage integration that directly processes coverage.json output:
-
tools/coverage_trend.py [::stranske/Workflows::]:
- Parses
coverage.jsonto extract coverage metrics - Used to generate trend analysis and identify hotspot files
- Called with
--coverage-jsonargument to load coverage data
- Parses
-
tools/coverage_guard.py [::stranske/Workflows::]:
- Loads
coverage.json(default path:coverage.json) to compare coverage against baseline - Extracts file-level coverage data to identify low-coverage hotspots
- Maintains coverage baseline breach tracking via GitHub issues
- Loads
-
Workflow Integration [::stranske/Workflows::]:
- Coverage is a pinned dev dependency in
pyproject.tomlfor the test suite - Multiple GitHub Actions workflows reference coverage artifacts and metrics
pyproject.tomlconfigures coverage with parallel mode and branch coverage enabled
- Coverage is a pinned dev dependency in
Potential Impact of v7.14.2 Changes [::stranske/Workflows::]:
The most relevant fix in coverage 7.14.2 for this project is:
- Output stream correction: Messages previously written to stdout are now written to stderr, improving JSON output capture with
coverage json -o -
Status: This change should be beneficial for the repository since it fixes JSON output capture, which directly supports the existing coverage.json parsing in tools/coverage_trend.py and tools/coverage_guard.py. The fix ensures cleaner JSON output when coverage reports are generated or piped.
The other fixes (connection leak, tool ID handling, wheel distribution) should have no negative impact on the Python-based coverage tools used in this repository.
🔇 Additional comments (1)
pyproject.toml (1)
20-20: LGTM!
|
Closing as superseded by Workflows source-of-truth pin update stranske/Workflows#2497. The coverage pin is owned by Workflows .github/workflows/autofix-versions.env and should propagate through Maint 52/dev-tool sync rather than a pyproject-only Renovate PR. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
1 participant
This PR contains the following updates:
==7.14.1→==7.14.2Release Notes
coveragepy/coveragepy (coverage)
v7.14.2Compare Source
Fix: some messages were being written to stdout, making
coverage json -o -useless for capturing JSON output. Now messages are written to stderr,fixing
issue 2197_.Fix:
CoverageDatakept one SQLite connection per thread that recordedcoverage, but never closed them when those threads terminated. On long runs
with many short-lived threads this leaked one file descriptor per dead
thread, eventually failing with
OSError: [Errno 24] Too many open files.Connections belonging to terminated threads are now closed and dropped.
Fixes
issue 2192_.Fix: when using sys.monitoring, we were assuming we could use the
COVERAGE_IDtool id. But other tools might also assume they could usethat id. Pre-allocated ids don't really make sense, so now we search for a
usable one instead. Fixes
issue 2187. Thanks,Matthew Lloyd <pull 2198_>.Following
the advice of cibuildwheel <no-13t_>_, we no longer distributewheels for Python 3.13 free-threaded.
.. _issue 2187: #2187
.. _issue 2192: #2192
.. _issue 2197: #2197
.. _pull 2198: #2198
.. _no-13t: https://py-free-threading.github.io/ci/#building-free-threaded-wheels-with-cibuildwheel
.. _changes_7-14-1:
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.