Skip to content

chore(deps): update dependency node to v24 #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renovate wants to merge 1 commit into from
Closed

chore(deps): update dependency node to v24 #5570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"features": {
"ghcr.io/devcontainers/features/github-cli:1": {},
"ghcr.io/devcontainers/features/node:1": {
"version": "20"
"version": "24"
},
"ghcr.io/devcontainers/features/docker-in-docker:2": {
"moby": "false"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/agents-auto-pilot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ jobs:
if: steps.check_enabled.outputs.enabled == 'true'
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: '20'
node-version: '24'

@coderabbitai coderabbitai Bot Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

Move this agent-workflow version bump to the source workflows repository.

Line 166 changes an agents-*.yml workflow in this repo, but this class of workflow is required to be maintained in stranske/Workflows and consumed from there. Keeping the bump here risks drift between source-of-truth and consumers.

As per coding guidelines, .github/workflows/agents-*.yml: “Agent workflow files (agents-*.yml) should be fixed in stranske/Workflows, not in this consumer repository.”

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/agents-auto-pilot.yml at line 166, The node-version change
to '24' in the agents-auto-pilot workflow should not be modified in this
consumer repository. According to coding guidelines, agent workflow files
(agents-*.yml) must be maintained in the stranske/Workflows repository as the
source-of-truth. Revert the node-version change from the agents-auto-pilot.yml
file in this repository and apply the same change to the corresponding workflow
file in the stranske/Workflows repository instead to maintain consistency and
prevent drift between the source and consumers.

Sources: Coding guidelines, Linked repositories


- name: Setup API client
if: steps.check_enabled.outputs.enabled == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/agents-weekly-metrics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: "20"
node-version: "24"

- name: Setup API client
uses: ./.github/actions/setup-api-client
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-12-playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v6
with:
node-version: '20'
node-version: '24'

- name: Install Playwright dependencies
run: |
Expand Down
Loading