Skip to content

chore: sync workflow templates - #914

Closed
stranske wants to merge 1 commit into
mainfrom
sync/workflows-164e3ba9e677
Closed

stranske wants to merge 1 commit into
mainfrom
sync/workflows-164e3ba9e677

Conversation

@stranske

Copy link
Copy Markdown
Owner

Sync Summary

Files Updated

  • agents-bot-comment-handler.yml: Bot comment handler - dispatches agents to address bot review comments (deprecated; replaced by agents-80-pr-event-hub.yml, removal no earlier than 2026-02-15)
  • aggregate_agent_metrics.py: Aggregates downloaded weekly agent metrics - required by agents-weekly-metrics.yml
  • terminal_disposition.js: Machine-readable terminal disposition records and source summaries
  • terminal_disposition_coverage.js: Warning-only terminal disposition source coverage preflight
  • bot_comment_auth_coverage.js: Warning-only bot-comment App auth coverage preflight
  • coverage_monitor_summary.js: Machine-readable weekly coverage monitor checkpoint
  • weekly_metrics_artifacts.js: Bounded weekly metrics artifact selection contract

Files Skipped

  • pr-00-gate.yml: File exists and sync_mode is create_only
  • ci.yml: File exists and sync_mode is create_only
  • dependabot.yml: File exists and sync_mode is create_only
  • llm_slots.json: None

Review Checklist

  • CI passes with updated workflows
  • No repo-specific customizations were overwritten

Source: stranske/Workflows
Manifest: .github/sync-manifest.yml

Automated sync from stranske/Workflows
Template hash: 164e3ba9e677

Changes synced from sync-manifest.yml
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Apr 26, 2026
Copilot AI review requested due to automatic review settings April 26, 2026 05:13
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Apr 26, 2026
@stranske-keepalive

Copy link
Copy Markdown
Contributor

⚠️ Action Required: Unable to determine source issue for PR #914. The PR title, branch name, or body must contain the issue number (e.g. #123, branch: issue-123, or the hidden marker ).

@stranske-keepalive

stranske-keepalive Bot commented Apr 26, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #914 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Disposition skipped (transient)
Gate success
Tasks 0/11 complete
Timeout 45 min (default)
Timeout usage 5m elapsed (13%, 40m remaining)
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

@stranske-keepalive

stranske-keepalive Bot commented Apr 26, 2026 •

Copy link
Copy Markdown
Contributor
Keepalive Work Log (click to expand)
# Time (UTC) Agent Action Result Files Tasks Progress Commit Gate
0 2026-04-26 05:15:50 Codex wait (missing-agent-label-transient) skipped — 0 0/11 — cancelled
0 2026-04-26 05:17:21 Codex wait (missing-agent-label-transient) skipped — 0 0/11 — cancelled
0 2026-04-26 05:19:22 Codex wait (missing-agent-label-transient) skipped — 0 0/11 — success

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs workflow-template updates from stranske/Workflows, expanding weekly metrics/coverage telemetry and adding more detailed terminal-disposition and bot-auth reporting to support the repo’s agents automation.

Changes:

  • Add wrapper-side terminal disposition artifact emission to the bot comment handler workflow.
  • Extend weekly metrics artifact selection + terminal disposition coverage reporting with priority-family statuses and verifier model compatibility signals.
  • Enhance metrics aggregation/reporting to include verifier model/mode and model-selection metadata summaries.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/aggregate_agent_metrics.py Adds verifier-model/mode and model-selection metadata counters to the aggregated markdown summary.
.github/workflows/agents-bot-comment-handler.yml Emits and uploads a wrapper “review-thread terminal disposition” artifact and exposes skip_reason output.
.github/scripts/weekly_metrics_artifacts.js Adds missing-priority-family and per-family status reporting to the artifact selection contract/markdown.
.github/scripts/terminal_disposition_coverage.js Adds verifier model compatibility checks and richer selection-family normalization/markdown output.
.github/scripts/terminal_disposition.js Extends terminal disposition normalization to carry model/mode metadata fields.
.github/scripts/coverage_monitor_summary.js Introduces a weekly “coverage monitor summary” contract (terminal + bot-auth reports).
.github/scripts/bot_comment_auth_coverage.js Improves organic evidence reporting with skipped/missing requirement details tied to wrapper expectations.

Comment on lines +258 to +267
- name: Upload wrapper terminal disposition
if: always()
uses: actions/upload-artifact@v7
with:
name: review-thread-terminal-disposition-${{ github.run_id }}
path: |
agent-metrics/review-thread-terminal-disposition.ndjson
terminal-disposition-summary.md
if-no-files-found: error
retention-days: 14

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/upload-artifact is referenced as a floating @v7 tag here, while other workflows in this repo pin upload-artifact v7 to a specific commit SHA. To keep the supply-chain posture consistent (and avoid unexpected action updates), pin this step to the same SHA used elsewhere in .github/workflows/.

Copilot uses AI. Check for mistakes.
Comment on lines +252 to +257
elif is_terminal_disposition:
verifier_mode = str(entry.get("verifier_mode") or "").strip().lower()
if verifier_mode != "evaluate":
disposition = entry.get("disposition") or entry.get("terminal_state") or "unknown"
missing_verifier_model_metadata[str(disposition)] += 1
model_selection_reason = entry.get("codex_model_selection_reason") or entry.get(

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new missing_verifier_model_metadata counter will include all terminal disposition records that lack a model and are not verifier_mode == evaluate. With the newly added review-thread terminal disposition records (wrapper artifacts), this will start flagging non-verifier terminal dispositions as “missing verifier model metadata”, skewing the verifier summary. Consider restricting this check to verifier terminal disposition records only (e.g., artifact_family == 'verifier-terminal-disposition' or another verifier-specific signal).

Copilot uses AI. Check for mistakes.

function overallStatus(monitors) {
if (monitors.some((monitor) => monitor.should_fail || monitor.status === 'fail')) return 'fail';
if (monitors.some((monitor) => ['missing', 'parse-error', 'warning'].includes(monitor.status))) {

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalizeStatus() can return unknown, but overallStatus() doesn’t treat unknown as a warning/failure condition. This can allow a malformed/unsupported report status to still yield an overall pass. Consider handling unknown explicitly (e.g., treat as warning) so unexpected report formats can’t silently pass the monitor.

Suggested change
if (monitors.some((monitor) => ['missing', 'parse-error', 'warning'].includes(monitor.status))) {
if (monitors.some((monitor) => ['missing', 'parse-error', 'warning', 'unknown'].includes(monitor.status))) {

Copilot uses AI. Check for mistakes.
@stranske

Copy link
Copy Markdown
Owner Author

Closing as superseded by the latest Workflows template sync PR #920. Please use #920 as the canonical sync lane for this batch.

This branch was previously deployed

1 inactive deployment
agent-standard — c2db21e7 Deployed Apr 26, 2026 by stranske via Update keepalive summary #6190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated Automated sync from Workflows sync Automated sync from Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants