chore: sync workflow templates - #856
Conversation
Automated sync from stranske/Workflows Template hash: 18397dc5e20f Changes synced from sync-manifest.yml
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📜 Recent review details🧰 Additional context used📓 Path-based instructions (5).github/workflows/**/*.{yml,yaml}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
.github/workflows/*.yml📄 CodeRabbit inference engine (CLAUDE.md)
Files:
.github/workflows/**/*.yml📄 CodeRabbit inference engine (AGENTS.md)
Files:
.github/workflows/agents-*.yml📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.py📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
🪛 LanguageTooldesign-system/README.md[uncategorized] ~50-~50: The official name of this software platform is spelled with a capital “H”. (GITHUB) 🔀 Multi-repo context stranske/WorkflowsBased on my exploration of the Linked repositories findingsstranske/Workflows (Source Template)Critical Breaking Changes in
Design System Distribution [::stranske/Workflows::]
Workflow Update [::stranske/Workflows::]
Impact Summary for
|
| Layer / File(s) | Summary |
|---|---|
HTML escaping and error normalization in ds_streamlit design-system/ds_streamlit.py |
Adds contextmanager and escape imports; escapes icon, title, desc in empty_state and title, body, action in notice before st.markdown; normalizes translate_error to run pattern checks on a lowercased copy of the exception text. |
diagnostics_expander, availability_badge(plain), humanize_id design-system/ds_streamlit.py |
Adds diagnostics_expander context manager wrapping a Streamlit expander with configurable expanded default; extends availability_badge with a plain flag (plain-text suffix vs. escaped HTML badge); rewrites humanize_id using namespace-segment scanning and a new private _human_label_segment helper that filters digits and hex-like tokens. |
CSS accessibility rules and font token fixes design-system/components.css, design-system/tokens.css |
Adds a .ds-scoped :focus-visible accent-outline rule for interactive elements; adds a prefers-reduced-motion: reduce override disabling the skeleton shimmer animation; adds quotes around BlinkMacSystemFont in --font-body and "Georgia" in .theme-paper --font-heading. |
README and PRESENTATION_PATTERNS docs design-system/README.md, design-system/PRESENTATION_PATTERNS.md |
README title updated to "Shared Design System", Files table updated to reference ds_streamlit.py, Status section rewritten to describe the sync workflow distribution path. PRESENTATION_PATTERNS adds explicit plain=False constraint for availability_badge in trusted-HTML-container context, with minor blank-line spacing adjustments across P2–P6 and Streamlit design kit sections. |
CI Workflow Pin Update
| Layer / File(s) | Summary |
|---|---|
setup-api-client action pin bump .github/workflows/agents-guard.yml |
Updates the pinned commit SHA for stranske/Workflows/.github/actions/setup-api-client in both the pull_request_target and pull_request "Workflows fallback" steps. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
- stranske/Template#834: Updates the same
agents-guard.ymlsetup-api-clientpin in thepull_request_targetandpull_requestfallback steps with a different commit SHA. - stranske/Template#835: Bumps the same
stranske/Workflows/.github/actions/setup-api-clientpinned SHA in both fallback steps ofagents-guard.yml. - stranske/Template#841: Changes the same
agents-guard.ymlsetup-api-clientrevision for bothpull_request_targetandpull_requestpaths.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check | The title 'chore: sync workflow templates' is generic and does not accurately represent the main change, which is a comprehensive sync of both workflow templates AND design system files from the Workflows repository. | Revise the title to reflect the full scope: 'chore: sync workflow templates and design system from Workflows' or similar to clarify that design system files are also being synced. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage | ✅ Passed | Docstring coverage is 87.50% which is sufficient. The required threshold is 80.00%. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
sync/workflows-18397dc5e20f
Comment @coderabbitai help to get the list of available commands.
Automated Status SummaryHead SHA: 8f2aab8
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Source SHA:
de0849c19ac81e04dc4b1ce6f95c6ec53a4db945Template hash:
18397dc5e20fSync branch:
sync/workflows-18397dc5e20fConsumer repo:
stranske/TemplateManifest:
.github/sync-manifest.ymlSummary by CodeRabbit
Release Notes
Accessibility Improvements
Security & Stability
Documentation