Skip to content

chore: sync workflow templates - #600

Closed
stranske wants to merge 1 commit into
mainfrom
sync/workflows-164e3ba9e677
Closed

chore: sync workflow templates#600
stranske wants to merge 1 commit into
mainfrom
sync/workflows-164e3ba9e677

Conversation

@stranske

Copy link
Copy Markdown
Owner

Sync Summary

Files Updated

  • agents-bot-comment-handler.yml: Bot comment handler - dispatches agents to address bot review comments (deprecated; replaced by agents-80-pr-event-hub.yml, removal no earlier than 2026-02-15)
  • aggregate_agent_metrics.py: Aggregates downloaded weekly agent metrics - required by agents-weekly-metrics.yml
  • terminal_disposition.js: Machine-readable terminal disposition records and source summaries
  • terminal_disposition_coverage.js: Warning-only terminal disposition source coverage preflight
  • bot_comment_auth_coverage.js: Warning-only bot-comment App auth coverage preflight
  • coverage_monitor_summary.js: Machine-readable weekly coverage monitor checkpoint
  • weekly_metrics_artifacts.js: Bounded weekly metrics artifact selection contract

Files Skipped

  • pr-00-gate.yml: File exists and sync_mode is create_only
  • ci.yml: File exists and sync_mode is create_only
  • dependabot.yml: File exists and sync_mode is create_only
  • llm_slots.json: None

Review Checklist

  • CI passes with updated workflows
  • No repo-specific customizations were overwritten

Source: stranske/Workflows
Manifest: .github/sync-manifest.yml

Automated sync from stranske/Workflows
Template hash: 164e3ba9e677

Changes synced from sync-manifest.yml
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Apr 26, 2026
Copilot AI review requested due to automatic review settings April 26, 2026 05:13
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Apr 26, 2026
@stranske-keepalive

Copy link
Copy Markdown
Contributor

⚠️ Action Required: Unable to determine source issue for PR #600. The PR title, branch name, or body must contain the issue number (e.g. #123, branch: issue-123, or the hidden marker ).

@stranske-keepalive

stranske-keepalive Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #600 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Disposition skipped (transient)
Gate success
Tasks 0/11 complete
Timeout 45 min (default)
Timeout usage 5m elapsed (12%, 40m remaining)
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

@stranske-keepalive

stranske-keepalive Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor
Keepalive Work Log (click to expand)
# Time (UTC) Agent Action Result Files Tasks Progress Commit Gate
0 2026-04-26 05:15:35 Codex wait (missing-agent-label-transient) skipped 0 0/11 cancelled
0 2026-04-26 05:17:33 Codex wait (missing-agent-label-transient) skipped 0 0/11 cancelled
0 2026-04-26 05:18:43 Codex wait (missing-agent-label-transient) skipped 0 0/11 success

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs workflow-template updates from stranske/Workflows, expanding weekly metrics/coverage telemetry and adding wrapper terminal-disposition artifacts for the deprecated bot-comment handler workflow.

Changes:

  • Extend weekly metrics aggregation and terminal-disposition coverage checks to track verifier model selection/compatibility signals.
  • Add wrapper terminal-disposition artifact emission to agents-bot-comment-handler.yml for better telemetry when the wrapper skips or dispatches.
  • Enhance weekly metrics artifact selection reporting with explicit priority-family status/missing-family reporting; add a weekly coverage monitor summary contract script.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/aggregate_agent_metrics.py Adds verifier model / selection-reason counters and “unsupported model” reporting to the markdown summary.
.github/workflows/agents-bot-comment-handler.yml Adds skip-reason outputs and emits/uploads a wrapper terminal-disposition artifact for observability.
.github/scripts/weekly_metrics_artifacts.js Adds priority-family status + missing-family reporting to the artifact selection contract/markdown.
.github/scripts/terminal_disposition_coverage.js Adds verifier model compatibility summary and includes it in coverage status/blockers + markdown output.
.github/scripts/terminal_disposition.js Extends terminal-disposition normalization to include model/selection-reason/verifier-mode metadata fields.
.github/scripts/coverage_monitor_summary.js Introduces a weekly “coverage monitor checkpoint” JSON/markdown summary contract generator.
.github/scripts/bot_comment_auth_coverage.js Adds wrapper→reusable invocation decision fields and improves organic-evidence reporting of skipped/missing requirements.

Comment on lines +253 to +256
verifier_mode = str(entry.get("verifier_mode") or "").strip().lower()
if verifier_mode != "evaluate":
disposition = entry.get("disposition") or entry.get("terminal_state") or "unknown"
missing_verifier_model_metadata[str(disposition)] += 1

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing_verifier_model_metadata is incremented for any terminal-disposition entry that lacks a model and has verifier_mode not equal to evaluate. This will also flag non-verifier terminal-disposition records (e.g., review-thread/wrapper dispositions) as missing verifier model metadata. Restrict this check to verifier records only (for example by checking artifact_family == 'verifier-terminal-disposition' / a verifier-specific source_type) before counting missing model metadata.

Suggested change
verifier_mode = str(entry.get("verifier_mode") or "").strip().lower()
if verifier_mode != "evaluate":
disposition = entry.get("disposition") or entry.get("terminal_state") or "unknown"
missing_verifier_model_metadata[str(disposition)] += 1
artifact_family = str(entry.get("artifact_family") or "").strip().lower()
source_type_text = str(entry.get("source_type") or "").strip().lower()
is_verifier_terminal_disposition = (
artifact_family == "verifier-terminal-disposition"
or "verifier" in source_type_text
or "verify" in source_type_text
)
if is_verifier_terminal_disposition:
verifier_mode = str(entry.get("verifier_mode") or "").strip().lower()
if verifier_mode != "evaluate":
disposition = entry.get("disposition") or entry.get("terminal_state") or "unknown"
missing_verifier_model_metadata[str(disposition)] += 1

Copilot uses AI. Check for mistakes.
Comment on lines +214 to +216
node <<'NODE'
const fs = require('fs');
const helperPath = './.github/scripts/terminal_disposition.js';

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job now runs an inline node script, but there is no actions/setup-node step to ensure a consistent Node version is available. Add a pinned actions/setup-node (matching the repo’s standard, e.g. Node 20) before running node (and ideally before ./.github/actions/setup-api-client, which also executes node).

Copilot uses AI. Check for mistakes.

- name: Upload wrapper terminal disposition
if: always()
uses: actions/upload-artifact@v7

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/upload-artifact is referenced by tag (@v7) instead of a pinned commit SHA. Other workflows in this repo pin actions to full SHAs; please pin this action similarly (with an inline major-version comment) to keep supply-chain protections consistent.

Suggested change
uses: actions/upload-artifact@v7
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v7

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated Automated sync from Workflows sync Automated sync from Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants