Skip to content

chore: sync workflow templates - #598

Closed
stranske wants to merge 1 commit into
mainfrom
sync/workflows-49bfb75a2f6f
Closed

chore: sync workflow templates#598
stranske wants to merge 1 commit into
mainfrom
sync/workflows-49bfb75a2f6f

Conversation

@stranske

Copy link
Copy Markdown
Owner

Sync Summary

Files Updated

  • agents-bot-comment-handler.yml: Bot comment handler - dispatches agents to address bot review comments (deprecated; replaced by agents-80-pr-event-hub.yml, removal no earlier than 2026-02-15)
  • aggregate_agent_metrics.py: Aggregates downloaded weekly agent metrics - required by agents-weekly-metrics.yml
  • terminal_disposition.js: Machine-readable terminal disposition records and source summaries
  • terminal_disposition_coverage.js: Warning-only terminal disposition source coverage preflight
  • bot_comment_auth_coverage.js: Warning-only bot-comment App auth coverage preflight
  • coverage_monitor_summary.js: Machine-readable weekly coverage monitor checkpoint
  • weekly_metrics_artifacts.js: Bounded weekly metrics artifact selection contract

Files Skipped

  • pr-00-gate.yml: File exists and sync_mode is create_only
  • ci.yml: File exists and sync_mode is create_only
  • dependabot.yml: File exists and sync_mode is create_only
  • llm_slots.json: None

Review Checklist

  • CI passes with updated workflows
  • No repo-specific customizations were overwritten

Source: stranske/Workflows
Manifest: .github/sync-manifest.yml

Automated sync from stranske/Workflows
Template hash: 49bfb75a2f6f

Changes synced from sync-manifest.yml
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Apr 26, 2026
Copilot AI review requested due to automatic review settings April 26, 2026 04:44
@agents-workflows-bot

Copy link
Copy Markdown
Contributor

⚠️ Action Required: Unable to determine source issue for PR #598. The PR title, branch name, or body must contain the issue number (e.g. #123, branch: issue-123, or the hidden marker ).

@agents-workflows-bot

agents-workflows-bot Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #598 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Disposition skipped (transient)
Gate success
Tasks 0/11 complete
Timeout 45 min (default)
Timeout usage 5m elapsed (12%, 40m remaining)
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

@agents-workflows-bot

agents-workflows-bot Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor
Keepalive Work Log (click to expand)
# Time (UTC) Agent Action Result Files Tasks Progress Commit Gate
0 2026-04-26 04:45:53 Codex wait (missing-agent-label-transient) skipped 0 0/11
0 2026-04-26 04:47:31 Codex wait (missing-agent-label-transient) skipped 0 0/11 cancelled
0 2026-04-26 04:49:00 Codex wait (missing-agent-label-transient) skipped 0 0/11 cancelled
0 2026-04-26 04:49:41 Codex wait (missing-agent-label-transient) skipped 0 0/11 success

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs workflow-template updates from stranske/Workflows, expanding weekly metrics/coverage telemetry and adding wrapper terminal-disposition reporting for the deprecated bot-comment handler workflow.

Changes:

  • Extend agent metrics aggregation and reporting to include verifier model + selection metadata.
  • Add artifact-selection diagnostics (priority family missing/status) and propagate them into terminal disposition coverage output.
  • Add wrapper terminal-disposition artifact emission for agents-bot-comment-handler runs; introduce a new coverage monitor summary script and enhance bot-comment auth coverage reporting.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/aggregate_agent_metrics.py Adds model / selection-reason / verifier-mode counters to the verifier summary and prints them in the markdown summary.
.github/workflows/agents-bot-comment-handler.yml Emits a wrapper terminal disposition artifact and threads through skip reasons for better telemetry.
.github/scripts/weekly_metrics_artifacts.js Adds “missing priority families” + per-family status reporting to the metrics artifact selector report/markdown.
.github/scripts/terminal_disposition_coverage.js Normalizes and renders priority-family selection status in terminal disposition coverage reports.
.github/scripts/terminal_disposition.js Extends terminal disposition normalization to include LLM model / selection reason / verifier mode fields.
.github/scripts/coverage_monitor_summary.js Adds a new summary contract to roll up coverage monitor reports into a single JSON/markdown output.
.github/scripts/bot_comment_auth_coverage.js Tracks reusable-invocation expectations and annotates organic evidence requirements as skipped/missing.

Comment on lines +258 to +267
- name: Upload wrapper terminal disposition
if: always()
uses: actions/upload-artifact@v7
with:
name: review-thread-terminal-disposition-${{ github.run_id }}
path: |
agent-metrics/review-thread-terminal-disposition.ndjson
terminal-disposition-summary.md
if-no-files-found: error
retention-days: 14

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/upload-artifact is referenced by the floating @v7 tag here, while the rest of the repo pins third-party actions to a full commit SHA (with an inline major-version comment). Please pin this to the same upload-artifact v7 SHA used elsewhere in workflows (e.g. agents-weekly-metrics.yml, agents-keepalive-loop.yml) to avoid supply-chain drift.

Copilot uses AI. Check for mistakes.
Comment on lines +206 to +216
- name: Write wrapper terminal disposition
if: always()
env:
RESOLVED_PR_NUMBER: ${{ steps.resolve.outputs.pr_number }}
REUSABLE_INVOCATION_EXPECTED: ${{ steps.resolve.outputs.should_run }}
SKIP_REASON: ${{ steps.resolve.outputs.skip_reason }}
run: |
mkdir -p agent-metrics
node <<'NODE'
const fs = require('fs');
const helperPath = './.github/scripts/terminal_disposition.js';

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job runs Node.js directly (the heredoc node invocation) and also uses ./.github/actions/setup-api-client (which calls node/npm internally), but there is no explicit actions/setup-node step. Other workflows in this repo consistently pin actions/setup-node (Node 20) before setup-api-client; add the same here so the workflow doesn’t depend on whatever Node version happens to be preinstalled on ubuntu-latest.

Copilot uses AI. Check for mistakes.
status: selectedCount > 0 ? 'selected' : (candidateCount > 0 ? 'available' : 'missing'),
candidate_count: candidateCount,
selected_count: selectedCount,
latest_candidate: selectedArtifact ? normalizeSelectionArtifact(selectedArtifact) : null,

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the fallback path (when report.priority_family_statuses doesn’t include a family), latest_candidate is being set from selectedArtifact. That conflates “latest available candidate” with “selected artifact” and can make the coverage markdown/table misleading. Consider leaving latest_candidate as null here (or populating it from actual candidate artifacts if you have them) and keep selected_artifact as the selected one.

Suggested change
latest_candidate: selectedArtifact ? normalizeSelectionArtifact(selectedArtifact) : null,
latest_candidate: null,

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated Automated sync from Workflows sync Automated sync from Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants