Skip to content

chore(deps): update dependency node to v24 #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renovate wants to merge 1 commit into from
Closed

chore(deps): update dependency node to v24 #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/agents-auto-pilot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ jobs:
if: steps.check_enabled.outputs.enabled == 'true'
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: '20'
node-version: '24'

@coderabbitai coderabbitai Bot Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

agents-*.yml changes should be made upstream in stranske/Workflows, then synced. Both edits introduce the same source-of-truth drift against repository workflow policy.

  • .github/workflows/agents-auto-pilot.yml#L166-L166: revert the local node-version bump and apply it in stranske/Workflows as the canonical fix path.
  • .github/workflows/agents-weekly-metrics.yml#L50-L50: revert the local node-version bump and consume the upstreamed change from stranske/Workflows.

As per coding guidelines, "agents-*.yml workflow files should be fixed in stranske/Workflows, not in the consumer repo".

📍 Affects 2 files
  • .github/workflows/agents-auto-pilot.yml#L166-L166 (this comment)
  • .github/workflows/agents-weekly-metrics.yml#L50-L50
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/agents-auto-pilot.yml at line 166, Revert the
`node-version: '24'` change at `.github/workflows/agents-auto-pilot.yml` line
166 and the corresponding `node-version` change at
`.github/workflows/agents-weekly-metrics.yml` line 50 back to their previous
values, since agents workflow files must be fixed upstream in the
`stranske/Workflows` repository per coding policy, not in local consumer
repositories. Apply the node-version update in the canonical
`stranske/Workflows` repository instead, then the consumer repositories will
consume the upstreamed change.

Source: Coding guidelines


- name: Setup API client
if: steps.check_enabled.outputs.enabled == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/agents-weekly-metrics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: "20"
node-version: "24"

- name: Setup API client
uses: ./.github/actions/setup-api-client
Expand Down
Loading