Skip to content

ci(coverage): turn on the reporting leg, and record that the 85% target is already met #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 2 commits into from
Aug 26, 2026
Merged

ci(coverage): turn on the reporting leg, and record that the 85% target is already met #2243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a2be0b
ci(coverage): turn on the reporting leg, and record that the 85% targ…
stranske Aug 25, 2026
ccba0ed
ci(coverage): raise the floor 60 -> 86, now that the baseline is set
stranske Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion .github/workflows/pr-00-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,25 @@ jobs:
with:
python-versions: '["3.12"]' # Single version, no multi-platform
typecheck: true
coverage-min: "60" # Target: 85% - tracking issue to be created
# RAISED 60 -> 86 on 2026-08-26, and the stale comment removed with it. That comment
# read "Target: 85% - tracking issue to be created" while measured coverage is 86.25%:
# the target was already MET, and had been for as long as reporting was off. A number
# nobody publishes cannot tell you that you already succeeded.
#
# 60 against 86.25% is a floor 26 points below reality -- it reports a pass on any
# input and could not fail if coverage fell by a quarter. Now matches
# config/coverage-baseline.json, set at the same measured current in #2245, so the soft
# gate and Maint Coverage Guard agree about this repo. 86 rather than 86.25 leaves the
# jitter tolerance where it belongs, in the guard's warn_drop of 1.0.
coverage-min: "86"
# Only the REPORTING leg was off: `enable-soft-gate` defaults to false upstream, so
# the Gate computed a coverage number every run and discarded it -- no trend
# artifact, no hotspot table, nothing for Maint Coverage Guard to read. Report-only:
# coverage_trend.py runs with --soft and always exits 0, so this cannot fail a PR.
# Measured 86.25% on 2026-08-25, which already MEETS the 85% target the line above
# calls untracked. The floor of 60 stays for now -- raising it is a gate change and
# belongs with the baseline work, not with turning reporting on.
enable-soft-gate: true
Comment thread
stranske marked this conversation as resolved.
format_check: false # Using ruff for formatting
working-directory: "."
artifact-prefix: "gate-"
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,3 +199,6 @@ node_modules/
!/.github/scripts/node_modules/**

# END WORKFLOWS STATUS FILES

# Local derived GitNexus cache
.gitnexus
Loading