Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/agents-guard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
github.event_name == 'pull_request_target' &&
steps.eligibility.outputs.should-run == 'true' &&
steps.api_client_base.outputs.available != 'true'
uses: "stranske/Workflows/.github/actions/setup-api-client@6c3391d38bbc20a4577ac42b9aa6c9dc4e462c09" # v1
uses: "stranske/Workflows/.github/actions/setup-api-client@a525e6e3e2431d302073de65723c6e022f4b02fa" # v1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ“ Maintainability & Code Quality | 🟠 Major | πŸ—οΈ Heavy lift

Update this pin in stranske/Workflows first.

This file matches the synced agents-*.yml workflow pattern, so bumping the fallback SHA only in the consumer repo creates drift from the source workflow. The linked upstream stranske/Workflows/.github/workflows/agents-guard.yml still carries the old 6c3391d... pin at the corresponding fallback steps, so the next sync can overwrite this change. As per coding guidelines, β€œFor synced workflows, prompts, scripts, and consumer docs (e.g., agents-*.yml, autofix.yml, .github/codex/ prompts) β€” fix them in stranske/Workflows first, not locally in the consumer repo.”

Also applies to: 183-183

πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/agents-guard.yml at line 114, The fallback SHA pin in the
synced agents workflow should not be updated only in this consumer repo. Revert
or leave the local `agents-guard.yml` pin as-is here, and first make the
corresponding change in the upstream `stranske/Workflows` source workflow so the
synced `setup-api-client` reference stays aligned. Check the matching fallback
steps in `agents-guard.yml` and keep the consumer file consistent with the
upstream `agents-*.yml` workflow pattern.

Sources: Coding guidelines, Linked repositories

with:
secrets: ${{ toJSON(secrets) }}
github_token: ${{ github.token }}
Expand Down Expand Up @@ -180,7 +180,7 @@ jobs:
steps.eligibility.outputs.should-run == 'true' &&
github.event_name == 'pull_request' &&
steps.api_client_head.outputs.available != 'true'
uses: "stranske/Workflows/.github/actions/setup-api-client@6c3391d38bbc20a4577ac42b9aa6c9dc4e462c09" # v1
uses: "stranske/Workflows/.github/actions/setup-api-client@a525e6e3e2431d302073de65723c6e022f4b02fa" # v1
with:
secrets: ${{ toJSON(secrets) }}
github_token: ${{ github.token }}
Expand Down
Loading