Skip to content

chore: sync workflow templates - #553

Closed
stranske wants to merge 1 commit into
mainfrom
sync/workflows-b64df2fe92cb
Closed

chore: sync workflow templates#553
stranske wants to merge 1 commit into
mainfrom
sync/workflows-b64df2fe92cb

Conversation

@stranske

@stranske stranske commented Jun 16, 2026

Copy link
Copy Markdown
Owner

Sync Summary

Files Updated

  • aggregate_agent_metrics.py: Aggregates downloaded weekly agent metrics - required by agents-weekly-metrics.yml
  • WORKFLOW_USER_GUIDE.md: Workflow user guide - explains the CI/agent system for repo consumers

Files Skipped

  • pr-00-gate.yml: File exists and sync_mode is create_only
  • ci.yml: File exists and sync_mode is create_only
  • renovate.json: File exists and sync_mode is create_only
  • cross-repo-smoke.yml: File exists and sync_mode is create_only
  • llm_slots.json: None

Review Checklist

  • CI passes with updated workflows
  • No repo-specific customizations were overwritten

Source: stranske/Workflows
Source SHA: 5646eec72d8a26c1bb053d602c977153c74cfadc
Template hash: b64df2fe92cb
Sync branch: sync/workflows-b64df2fe92cb
Consumer repo: stranske/Pension-Data
Manifest: .github/sync-manifest.yml

Summary by CodeRabbit

Release Notes

  • Documentation
    • Updated agents:allow-change label documentation with clarified scope and application behavior for automated dependency pull requests.

Automated sync from stranske/Workflows
Template hash: b64df2fe92cb

Changes synced from sync-manifest.yml
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Jun 16, 2026
@stranske
stranske temporarily deployed to agent-standard June 16, 2026 14:06 — with GitHub Actions Inactive
@stranske
stranske temporarily deployed to agent-standard June 16, 2026 14:06 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 383ec483-a31b-4f56-8a1c-ae4f7e6951ac

📥 Commits

Reviewing files that changed from the base of the PR and between 74da5f3 and dd13a76.

📒 Files selected for processing (2)
  • WORKFLOW_USER_GUIDE.md
  • scripts/aggregate_agent_metrics.py
📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js,jsx,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use conventional commit message format with type prefix: type/description where types include fix, feat, chore, docs. For example: fix: resolve mypy type error or feat: add new authentication method.

Files:

  • scripts/aggregate_agent_metrics.py
🔇 Additional comments (6)
WORKFLOW_USER_GUIDE.md (1)

168-168: LGTM!

scripts/aggregate_agent_metrics.py (5)

12-12: LGTM!


306-314: LGTM!


317-386: LGTM!


389-399: LGTM!


402-429: LGTM!


📝 Walkthrough

Walkthrough

scripts/aggregate_agent_metrics.py drops its import of read_ndjson_file from src.ndjson_parser and replaces it with a local streaming implementation (_read_ndjson_file_streaming, _format_parse_error, read_ndjson_file) that handles per-line parse errors and a legacy JSON fallback. read_metric_ndjson_files is updated to use the new reader via an inline callback. WORKFLOW_USER_GUIDE.md moves and expands the agents:allow-change label description.

Changes

Local streaming NDJSON reader

Layer / File(s) Summary
Streaming NDJSON parser and local read_ndjson_file
scripts/aggregate_agent_metrics.py
Adds Callable to imports; introduces _format_parse_error and _read_ndjson_file_streaming with line-by-line parsing, size/line-limited legacy JSON fallback buffering, and per-line error formatting; replaces the formerly imported read_ndjson_file with a local wrapper delegating to the streaming parser.
read_metric_ndjson_files caller update
scripts/aggregate_agent_metrics.py
Switches to calling _read_ndjson_file_streaming directly with an inline record_error callback that builds ParseErrorDetail objects via _append_parse_error_detail; clears file errors on legacy-fallback success instead of returning canonicalized errors.

agents:allow-change label documentation

Layer / File(s) Summary
Label entry repositioned and expanded
WORKFLOW_USER_GUIDE.md
Removes the agents:allow-change row from its earlier table location and re-adds it with a description that explicitly scopes the CODEOWNER bypass to automated dependency PRs and states that manual application does not bypass guard enforcement.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'chore: sync workflow templates' is vague and does not reflect the actual substantive code changes in the PR, particularly the significant implementation of NDJSON parsing logic in aggregate_agent_metrics.py. Consider a more descriptive title that captures the main changes, such as 'refactor: implement local NDJSON reader in aggregate_agent_metrics.py' or include both the template sync and code changes more explicitly.
Docstring Coverage ⚠️ Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/workflows-b64df2fe92cb

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Workflow state fingerprint for Keepalive Loop Reporter. Do not edit.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Workflow state fingerprint for Agents Gate Followups. Do not edit.

@stranske

Copy link
Copy Markdown
Owner Author

Closing as superseded by newer workflow-template sync PR #554 from the latest Workflows sync wave.

@stranske stranske closed this Jun 16, 2026
@stranske-keepalive
stranske-keepalive Bot deleted the sync/workflows-b64df2fe92cb branch June 17, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated Automated sync from Workflows sync Automated sync from Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant