-
Notifications
You must be signed in to change notification settings - Fork 0
feat(advisor): give every declared binding a caller — 22 unbound → 1 #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
778ec56
feat(advisor): give every declared binding a caller — 22 unbound → 1
f0926fe
fix(verify): bound the ci consult's ledger wait, and format at the pi…
6cdc6c1
fix(verify): the ci-consult selftest asserted against the live ledger…
5c71062
fix(advisor): drop the ci consult — #68 showed the surface has nothin…
77f0778
fix(advisor): declare the tick phase consults, and retire the lane de…
346ea68
style: black at the pinned width (100)
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Documentation still describes the removed
ciconsult.capability_advisor.pylines 949-968 declare thecisurface withNO_BINDINGand record that noverify.pyconsult was added, so both documents now assert a caller that does not exist.README.md#L213-L220: remove or rewrite the bullet that statesverify.pyconsults withsurface: "ci"and prints a summary line on every PR.ARCHITECTURE.md#L508-L513: delete thecirow from the caller table, and remove the "Theciconsult line reports the pair on every PR" sentence at lines 533-534.🧰 Tools
🪛 LanguageTool
[style] ~215-~215: This phrase is redundant. Consider writing “consults”.
Context: ...eady executes the admission gate, so it consults with
surface: "ci"and prints one summar...(CONSULT_WITH)
📍 Affects 2 files
README.md#L213-L220(this comment)ARCHITECTURE.md#L508-L513🤖 Prompt for AI Agents