fix(verify): raise the collection floor to the post-merge reality (345 -> 353) - #15
Conversation
…5 -> 353) The floor committed in #12 was measured on a branch cut before #13 (research panels, rounds, domain studies) merged, so main's recorded floor sat 8 tests BELOW what main actually collects. A floor below reality fails in the permissive direction: those 8 tests could have stopped being collected and the check would still have passed, which is exactly the hole .verify-floor.json exists to close — a silent drop in tests-collected reads identically to tests passing. Measure the floor on the merge result, not on the branch. Ceilings unchanged (24/7/2). verify.py: 353 passed, 0 failed, 0/24 skipped, 81 selftests, 5/5 gates. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 41 minutes Limit details: You’ve used the included review currently available. Your 66 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
The floor committed in #12 was measured on a branch cut before #13 (research panels, rounds, domain studies) merged, so main's recorded floor sat 8 tests below what main actually collects (345 vs 353).
A floor below reality fails in the permissive direction: those 8 tests could have stopped being collected and the check would still have passed — exactly the hole
.verify-floor.jsonexists to close, since a silent drop in tests-collected reads identically to tests passing.Measure the floor on the merge result, not on the branch. Ceilings unchanged (24/7/2).
python3 verify.py: 353 passed, 0 failed, 0/24 skipped, 81 selftests, 5/5 gates green — run from both the canonical tree and the exec mirror.🤖 Generated with Claude Code