Skip to content

chore: sync workflow templates #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 1 commit into from
Mar 24, 2026
Merged

chore: sync workflow templates #777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maint-76-claude-code-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ jobs:
- name: Run Claude Code Review
id: claude
continue-on-error: true
uses: anthropics/claude-code-action@220272d38887a1caed373da96a9ffdb0919c26cc
uses: anthropics/claude-code-action@220272d38887a1caed373da96a9ffdb0919c26cc # v1
with:
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
allowed_bots: '*'
Expand Down
38 changes: 37 additions & 1 deletion scripts/langchain/followup_issue_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,7 @@ def extract_verification_data(comment_body: str) -> VerificationData:
# Extract provider verdicts (from comparison reports)
lines = comment_body.splitlines()
in_provider_table = False
provider_summary_concerns: list[str] = []
for line in lines:
if re.search(
r"\|\s*Provider\s*\|\s*Model\s*\|\s*Verdict\s*\|\s*Confidence",
Expand All @@ -556,11 +557,17 @@ def extract_verification_data(comment_body: str) -> VerificationData:
verdict = cols[2]
confidence_text = cols[3]
confidence = _parse_confidence_value(confidence_text)
data.provider_verdicts[provider] = {
summary_text = cols[4].strip() if len(cols) >= 5 else ""
entry = {
"model": model,
"verdict": verdict.strip(),
"confidence": confidence,
}
if summary_text:
entry["summary"] = summary_text
if verdict.strip().upper() != "PASS":
provider_summary_concerns.append(summary_text)
Comment on lines +568 to +569
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provider_summary_concerns appends summary_text for any non-PASS verdict, but the upstream report can emit placeholder values like "N/A" (and very short fragments). Those end up becoming blocking concerns/tasks after all_concerns.extend(...). Add filtering here (e.g., skip "N/A"/empty and enforce a minimum length) before appending to provider_summary_concerns.

Suggested change
if verdict.strip().upper() != "PASS":
provider_summary_concerns.append(summary_text)
# Only treat the summary as a blocking concern if it is non-placeholder
# and contains a minimal amount of information.
cleaned_summary = summary_text.strip()
if cleaned_summary:
lowered = cleaned_summary.lower()
is_placeholder = lowered in {"n/a", "na"}
has_min_length = len(cleaned_summary) >= 10
if (
verdict.strip().upper() != "PASS"
and not is_placeholder
and has_min_length
):
provider_summary_concerns.append(summary_text)

Copilot uses AI. Check for mistakes.
data.provider_verdicts[provider] = entry

# Extract verdicts from provider detail sections as a fallback.
current_provider = None
Expand Down Expand Up @@ -665,6 +672,8 @@ def extract_verification_data(comment_body: str) -> VerificationData:
if concern and len(concern) > 15:
all_concerns.append(concern)

all_concerns.extend(provider_summary_concerns)

# Deduplicate while preserving order, and filter out spurious entries
seen: set[str] = set()
data.concerns = []
Expand Down Expand Up @@ -1475,6 +1484,33 @@ def _generate_without_llm(
body_parts.append(f"- {concern}")
body_parts.extend(["", "</details>"])

body_parts.extend(
[
"",
"## verify:compare Analysis",
"",
f"- Resolved verdict: {verdict}",
]
)
for concern in blocking_concerns[:10]:
body_parts.append(f"- Concern: {concern}")
for concern in advisory_concerns[:10]:
body_parts.append(f"- Advisory: {concern}")

body_parts.extend(
[
"",
"## verify:compare Evidence",
"",
]
)
for provider, data in verification_data.provider_verdicts.items():
evidence = f"- {provider}: {data.get('verdict', 'Unknown')} @ {data.get('confidence', 0)}%"
summary = data.get("summary")
if summary:
evidence += f" ({summary})"
body_parts.append(evidence)

# Add background context in collapsible section
body_parts.extend(
[
Expand Down
Loading