test(diff): lock in env-driven DB defaults for diff_holdings

[stranske]

Summary

• add a focused regression test that ensures diff_holdings() calls connect_db() with default configuration when no connection is passed
• this prevents reintroducing a hardcoded DB-path behavior in the CLI/code path

Testing

• pytest -q tests/test_diff_holdings.py
• ruff check tests/test_diff_holdings.py

[agents-workflows-bot]

⚠️ Action Required: Unable to determine source issue for PR #739. The PR title, branch name, or body must contain the issue number (e.g. #123, branch: issue-123, or the hidden marker ).

[Copilot]

Pull request overview

Adds a regression test to ensure diff_holdings() uses connect_db() defaults (i.e., calls connect_db() with no explicit path) when no connection is provided, preventing reintroduction of hardcoded DB-path behavior.

Changes:

• Import the diff_holdings module object for targeted monkeypatching of connect_db.
• Add a focused test that verifies diff_holdings() calls connect_db() with no db_path argument and closes the owned connection.

[stranske-keepalive]

🤖 Keepalive Loop Status

PR #739 | Agent: Codex | Iteration 0/5

Current State

Metric	Value
Iteration progress	[----------] 0/5
Action	wait (missing-agent-label)
Disposition	skipped (transient)
Gate	success
Tasks	0/4 complete
Timeout	45 min (default)
Timeout usage	2m elapsed (5%, 43m remaining)
Keepalive	❌ disabled
Autofix	❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

[stranske-keepalive]

Keepalive Work Log (click to expand)

#	Time (UTC)	Agent	Action	Result	Files	Tasks	Progress	Commit	Gate
0	2026-03-02 03:51:58	Codex	wait (missing-agent-label-transient)	skipped	—	0	0/4	—	success
0	2026-03-02 04:20:14	Codex	wait (missing-agent-label-transient)	skipped	—	0	0/4	—	success