fix(etl): guard daily_diffs schema on Postgres#737
Merged
Conversation
Contributor
Contributor
🤖 Keepalive Loop StatusPR #737 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
Contributor
Keepalive Work Log (click to expand)
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the daily diff ETL flow to avoid running SQLite-only DDL against Postgres by validating the daily_diffs table early, while preserving the existing “create on demand” behavior for SQLite dev/test runs.
Changes:
- Updated
_ensure_daily_diffs_table()to createdaily_diffsonly for SQLite and to fail fast on non-SQLite connections. - Added regression assertions to ensure the Postgres path does not emit SQLite-specific DDL (e.g.,
AUTOINCREMENT,CREATE TABLE IF NOT EXISTS).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
etl/daily_diff_flow.py |
Adds Postgres-side existence check for daily_diffs and keeps SQLite table creation behavior. |
tests/test_daily_diff.py |
Strengthens the Postgres-flow test to assert the new guard query runs and SQLite DDL is not emitted. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daily_diff_flowwhendaily_diffsis missing on Postgres, instead of executing SQLite-only assumptions later in the flowTesting
pytest -q tests/test_daily_diff.py