chore: sync workflow templates - #1581
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (7)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@coderabbitai review |
|
@codex review |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19be63bb15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _NODE_SUFFIX = re.compile(r"::.+$") # pytest node ids: tests/x.py::test_y | ||
| _ORIGINAL_ISSUE_BLOCK_RE = re.compile( | ||
| r"<details\b[^>]*>\s*<summary>Original Issue</summary>\s*" | ||
| r"(?P<fence>`{3,})text\s*\n(?P<inner>.*?)\n(?P=fence)\s*</details>", |
There was a problem hiding this comment.
Ignore tilde-fenced provenance blocks
When an existing formatted issue uses a ~~~text Original Issue archive, this regex does not strip it, so stale paths inside the archive are still counted by _cited_paths and can incorrectly trigger the wrong-repository rejection. The formatter explicitly recognizes both backtick and tilde fences in scripts/langchain/issue_formatter.py:480-483; accept the same alternatives here and update the Workflows sync source.
AGENTS.md reference: AGENTS.md:L40-L43
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed as source-owned. The bounded fix is open in stranske/Workflows#3064 with root/template parity and a tilde-fence regression. This generated PR remains unmergeable; Maint 68 will refresh this stable candidate in place after the source fix merges.
19be63b to
32ae24f
Compare
|
@codex review |
|
@coderabbitai review |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32ae24f349
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const baseRef = resolveBaseRef(process.env.INPUT_BASE_REF || '', githubContext); | ||
| // The stable-delivery contract is loaded from the exact trusted base SHA. | ||
| // Make that object available before evaluating the seal. | ||
| fetchBaseRef(baseRef, githubContext); |
There was a problem hiding this comment.
Avoid fetching the base twice per classification
For every pull_request run inspected in .github/workflows/pr-00-gate.yml, this unconditional call invokes fetchBaseRef(), which executes two sequential git fetch commands; listChangedFiles() then invokes the same helper again. Ordinary PRs—not only stable sync deliveries—therefore perform four remote fetches instead of two before classification. Restrict the early fetch to stable-delivery branches or reuse the completed fetch, and apply the fix in the Workflows source before syncing it here. (git fetch -h confirms each invocation uses the remote/refspec form git fetch [<options>] [<repository> [<refspec>...]].)
AGENTS.md reference: AGENTS.md:L22-L22
Useful? React with 👍 / 👎.
|
Source-owned finding accepted. The bounded Workflows fix is open at stranske/Workflows#3065. This generated PR remains blocked; Maint 68 will refresh this same candidate branch after the source fix merges. |
32ae24f to
e019778
Compare
|
@codex review |
|
@coderabbitai review |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e019778abc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await github.rest.actions.createWorkflowDispatch({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| workflow_id: 'agents-keepalive-loop.yml', |
There was a problem hiding this comment.
Dispatch retries through the consolidated workflow
For any non-terminal automation-owned failure, this dispatch targets agents-keepalive-loop.yml, but that workflow does not exist in this consumer; the current implementation is agents-81-gate-followups.yml. The caught 404 leaves recovery dependent on adding agent:retry, and because the consolidated workflow neither consumes nor removes that persistent label, subsequent failures cannot generate another labeled event, so the promised bounded retry can stall after its first attempt. Target the consolidated workflow used by the sweep instead.
AGENTS.md reference: AGENTS.md:L47-L57
Useful? React with 👍 / 👎.
|
Source-owned finding accepted and fixed in stranske/Workflows#3066. This generated PR remains blocked; a no-filter Maint 68 canary will refresh this same candidate PR after the source fix merges. |
e019778 to
d277bb7
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
d277bb7 to
8cdf98f
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cdf98f4ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pre_commit_changes, pre_commit_errors = sync_pre_commit_config( | ||
| PRE_COMMIT_FILE, pins, apply=args.apply | ||
| ) | ||
| changes.extend(pre_commit_changes) |
There was a problem hiding this comment.
Keep newly managed pre-commit revisions synchronized
Once this unconditional pre-commit check is added, the documented python scripts/sync_dev_dependencies.py --check command fails on this commit: the checked-in config still has Black 24.3.0, Ruff v0.3.3, and mypy v1.10.0 while the pin file requires 26.5.1, v0.16.2, and v2.3.0. Include the companion managed-config updates in the generated sync (or defer enforcement until they are applied), otherwise a freshly synced consumer is immediately reported as out of sync.
AGENTS.md reference: AGENTS.md:L40-L43
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed source-first in stranske/Workflows#3072. Managed pre-commit revisions are now explicitly owned by Maint 52 via --pre-commit; ordinary workflow-sync validation defers that separate dependency surface so a Maint 68 candidate cannot fail before its dependency wave lands. This candidate remains unsealed until refreshed.
8cdf98f to
e3c5865
Compare
Automated sync from stranske/Workflows Template hash: 7a99d523d28c Changes synced from sync-manifest.yml
e3c5865 to
b787817
Compare
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Source SHA:
590ae8053b0ac6ce1f5efd36e9379f240d794e0fTemplate hash:
7a99d523d28cConsumer-sync plan ID:
sha256:7a99d523d28c8148ab3219144e30e97258a6127dae3b08a9c6937b5da1f0aa78Sync phase:
canarySync branch:
sync/workflows-candidateConsumer repo:
stranske/Manager-DatabaseManifest:
.github/sync-manifest.ymlautofix: false