Conversation
Automated sync from stranske/Workflows Template hash: 5ffae5632ff0 Changes synced from sync-manifest.yml
🤖 Keepalive Loop StatusPR #146 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
|
Status | ✅ no new diagnostics |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbde2b9d4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const { parseScopeTasksAcceptanceSections } = require('./issue_scope_parser'); | ||
| const { loadKeepaliveState, formatStateComment } = require('./keepalive_state'); | ||
| const { resolvePromptMode } = require('./keepalive_prompt_routing'); | ||
| const { classifyError, ERROR_CATEGORIES } = require('./error_classifier'); |
There was a problem hiding this comment.
Add missing keepalive_prompt_routing module
The new prompt-routing imports point to ./keepalive_prompt_routing, but that module does not exist anywhere in the repository (rg keepalive_prompt_routing finds nothing). Any workflow step that loads this script will throw Cannot find module './keepalive_prompt_routing' before it can run, so keepalive loop execution (and the instruction template helper, which has the same import) will fail immediately rather than processing tasks.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR syncs workflow templates from the upstream stranske/Workflows repository, introducing enhanced keepalive loop functionality with prompt routing, task tracking, and verification support.
Key Changes:
- Adds dynamic prompt routing system with support for fix_ci, verify, and normal modes
- Implements attempt history and task tracking to avoid repeating recently attempted tasks
- Enhances transient error detection for dirty git state and infrastructure issues
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/scripts/keepalive_loop.js |
Adds prompt routing, attempt/task history tracking, verification flow, improved transient error classification, and focus task suggestion |
.github/scripts/keepalive_instruction_template.js |
Refactors to support multiple template paths with dynamic mode-based resolution and fallback handling |
.github/scripts/error_classifier.js |
Adds transient patterns for git workspace state issues (unexpected changes, untracked files, workflow artifacts) |
.github/scripts/agents-guard.js |
Allows automated PRs (dependabot, renovate) to bypass codeowner approval when they have the allow label |
|
|
||
| const { parseScopeTasksAcceptanceSections } = require('./issue_scope_parser'); | ||
| const { loadKeepaliveState, formatStateComment } = require('./keepalive_state'); | ||
| const { resolvePromptMode } = require('./keepalive_prompt_routing'); |
There was a problem hiding this comment.
This import references a module 'keepalive_prompt_routing' that doesn't exist in the repository. The file .github/scripts/keepalive_prompt_routing.js is missing but is required by both keepalive_loop.js (line 8) and keepalive_instruction_template.js (line 5). This will cause a runtime error when the script attempts to load. The missing module should be added to the PR, or the import should be removed and the functionality implemented locally.
|
|
||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| const { resolvePromptMode } = require('./keepalive_prompt_routing'); |
There was a problem hiding this comment.
This import references a module 'keepalive_prompt_routing' that doesn't exist in the repository. The file .github/scripts/keepalive_prompt_routing.js is missing but is required. This will cause a runtime error when the script attempts to load. The missing module should be added to the PR, or the import should be removed and the functionality implemented locally.
|
Superseded by newer sync PR that was merged. |
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Manifest:
.github/sync-manifest.yml