Conversation
Automated sync from stranske/Workflows Template hash: 3ad5d39a380a Changes synced from sync-manifest.yml
stranske
added
sync
stranske
temporarily deployed
to
agent-standard
GitHub Actions
Inactive
stranske
temporarily deployed
to
agent-standard
GitHub Actions
Inactive
🤖 Keepalive Loop StatusPR #143 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
|
Status | ✅ no new diagnostics |
There was a problem hiding this comment.
Pull request overview
This PR syncs workflow template files from the central stranske/Workflows repository, focusing on improvements to the keepalive loop's task reconciliation functionality.
- Fixes a string escaping issue in the GitHub Actions workflow by using environment variables instead of inline template literals for JSON data
- Adds defensive validation checks to prevent errors when repository context is missing
- Refactors source counting logic to be more maintainable and consistent across return paths
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/agents-keepalive-loop.yml |
Introduces environment variable approach for LLM_COMPLETED_TASKS to avoid JavaScript string escaping issues when passing JSON data to the script |
.github/scripts/keepalive_loop.js |
Adds validation for repo context, refactors source counting to track LLM vs commit-based task completions more consistently, and ensures all return statements include source tracking data |
| */ | ||
| async function autoReconcileTasks({ github, context, prNumber, baseSha, headSha, llmCompletedTasks, core }) { | ||
| const log = (msg) => core?.info?.(msg) || console.log(msg); | ||
| const sources = { llm: 0, commit: 0 }; | ||
|
|
||
| if (!context?.repo?.owner || !context?.repo?.repo || !prNumber) { | ||
| log('Skipping reconciliation: missing repo context or PR number.'); | ||
| return { | ||
| updated: false, | ||
| tasksChecked: 0, | ||
| details: 'Missing repo context or PR number', | ||
| sources, | ||
| }; | ||
| } | ||
|
|
||
| // Get current PR body | ||
| let pr; |
There was a problem hiding this comment.
The JSDoc return type documentation is incomplete. The function now returns an object with a sources property (containing llm and commit counts), but this is not documented in the return type annotation. The return type should be updated to include the sources field.
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Manifest:
.github/sync-manifest.yml