Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/artifact-cache/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ runs:

- name: Restore artifact cache
id: restore
uses: actions/cache@v5
uses: actions/cache@v6

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Do not update synced files locally; fix in upstream Workflows repository first.

This action file is synced from stranske/Workflows and should be updated there, not in the consumer repo. Additionally, the linked repository research shows 12 other actions/cache@v5 instances in the Workflows repository that are not included in this update:

  • health-42-actionlint.yml (2 instances)
  • maint-52-validate-workflows.yml (1 instance)
  • reusable-10-ci-python.yml (7 instances)
  • reusable-agents-verifier.yml (2 instances)

This incomplete migration creates version inconsistency across your caching infrastructure, with some workflows using v6 while others remain on v5. The next sync from Workflows will overwrite this local change back to v5, creating churn.

Resolution: Apply the v6 update in the upstream stranske/Workflows repository across all cache action instances, then sync to consumer repos.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/actions/artifact-cache/action.yml at line 62, This file is synced
from the upstream stranske/Workflows repository and should not be updated
locally. Instead, navigate to the upstream Workflows repository and update all
instances of actions/cache@v5 to actions/cache@v6 across the files mentioned:
health-42-actionlint.yml (2 instances), maint-52-validate-workflows.yml (1
instance), reusable-10-ci-python.yml (7 instances), and
reusable-agents-verifier.yml (2 instances). Once all 12 instances in the
upstream repository are updated consistently to v6, sync those changes back to
this consumer repository rather than making local modifications that will be
overwritten on the next sync.

Sources: Coding guidelines, Linked repositories

with:
path: ${{ steps.prepare.outputs.artifact-path }}
key: ${{ steps.prepare.outputs.cache-key }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/agents-auto-pilot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ jobs:

- name: Cache pip (LLM requirements)
if: steps.check_enabled.outputs.enabled == 'true'
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5
uses: actions/cache@2c8a9bd7457de244a408f35966fab2fb45fda9c8 # v6

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if agents-auto-pilot.yml exists and get its content around line 225
if [ -f ".github/workflows/agents-auto-pilot.yml" ]; then
  echo "=== agents-auto-pilot.yml exists ==="
  sed -n '220,230p' .github/workflows/agents-auto-pilot.yml | cat -n
else
  echo "agents-auto-pilot.yml not found"
fi

# Look for sync configuration/manifest files
echo -e "\n=== Looking for sync configuration ==="
find . -name "*sync*" -o -name "*manifest*" | head -20

Repository: stranske/Inv-Man-Intake

Length of output: 1004


🏁 Script executed:

#!/bin/bash
# Check if agents-auto-pilot.yml exists in Workflows
if [ -f ".github/workflows/agents-auto-pilot.yml" ]; then
  echo "=== Workflows/agents-auto-pilot.yml exists ==="
  sed -n '220,230p' .github/workflows/agents-auto-pilot.yml | cat -n
else
  echo "agents-auto-pilot.yml not found in Workflows"
fi

# Look for sync manifest in Workflows
echo -e "\n=== Looking for sync configuration ==="
find . -name "*sync*" -o -name "*manifest*" | head -20

Repository: stranske/Workflows

Length of output: 1697


🏁 Script executed:

#!/bin/bash
# Read the sync-manifest to understand which files are synced
cat .github/sync-manifest.yml | grep -A 5 -B 5 "agents-auto-pilot"

Repository: stranske/Workflows

Length of output: 2992


Do not patch agents-*.yml locally; update upstream Workflows repo first.

Line 225 changes a synchronized agents-auto-pilot.yml workflow in the consumer repo. This file is actively synced from stranske/Workflows (per sync-manifest), where the same line still pins v5. Updating it locally will be overwritten on the next sync.

Fix this in stranske/Workflows first, then sync down. As per coding guidelines: "agents-*.yml workflow files should be fixed in stranske/Workflows, not locally in the consumer repo."

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/agents-auto-pilot.yml at line 225, The modification to the
actions/cache version pin in the agents-auto-pilot.yml file should not be made
locally since this workflow file is automatically synced from the upstream
stranske/Workflows repository where the same line still pins v5. Instead, revert
the local change to this file and apply the actions/cache version update in the
stranske/Workflows repository first, then allow the sync mechanism to update
this consumer repository with the change. Do not modify agents-*.yml workflow
files directly in the consumer repo.

Sources: Coding guidelines, Linked repositories

with:
path: |
~/.cache/pip
Expand Down
Loading