-
Notifications
You must be signed in to change notification settings - Fork 0
chore: sync workflow templates #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| ## Workflow Source | ||
|
|
||
| Started from: | ||
| - [ ] GitHub issue: # | ||
| - [ ] Direct PR / remote GitHub work | ||
| - [ ] Local Codex/user request | ||
| - [ ] Automation run | ||
| - [ ] Review follow-up from PR # | ||
| - [ ] Sync / maintenance campaign | ||
| - [ ] Dependabot or dependency update | ||
| - [ ] Do not automate | ||
|
|
||
| Automation intent: | ||
| - [ ] Verifier should review this | ||
| - [ ] Keepalive may manage this PR | ||
| - [ ] Human-only unless checks fail | ||
|
|
||
| Notes: | ||
| <!-- If there is no linked issue, briefly describe the source. Automation also accepts workflow source labels such as workflow:source-direct-pr. --> | ||
|
|
||
| ## Summary | ||
|
|
||
|
|
||
| ## Testing |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -140,6 +140,11 @@ function buildCoverageMonitorSummary(options = {}) { | |||||
| const terminal = summarizeReport(readJsonReport(options.terminal_report, 'terminal-disposition')); | ||||||
| const botAuth = summarizeReport(readJsonReport(options.bot_auth_report, 'bot-comment-auth')); | ||||||
| const monitors = [terminal, botAuth]; | ||||||
| if (cleanString(options.pr_source_context_report)) { | ||||||
| monitors.push( | ||||||
| summarizeReport(readJsonReport(options.pr_source_context_report, 'pr-source-context')) | ||||||
| ); | ||||||
| } | ||||||
| const status = overallStatus(monitors); | ||||||
| const hardBlockActive = monitors.some((monitor) => monitor.hard_block_active); | ||||||
| const shouldFail = monitors.some((monitor) => monitor.should_fail); | ||||||
|
|
@@ -211,6 +216,8 @@ function parseArgs(argv = process.argv.slice(2)) { | |||||
| process.env.COVERAGE_MONITOR_TERMINAL_JSON || 'terminal-disposition-coverage.json', | ||||||
| bot_auth_report: | ||||||
| process.env.COVERAGE_MONITOR_BOT_AUTH_JSON || 'bot-comment-auth-coverage-summary.json', | ||||||
| pr_source_context_report: | ||||||
| process.env.COVERAGE_MONITOR_PR_SOURCE_CONTEXT_JSON || 'pr-source-context-coverage.json', | ||||||
|
||||||
| process.env.COVERAGE_MONITOR_PR_SOURCE_CONTEXT_JSON || 'pr-source-context-coverage.json', | |
| process.env.COVERAGE_MONITOR_PR_SOURCE_CONTEXT_JSON || '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parseArgsnow defaultspr_source_context_reporttopr-source-context-coverage.json, which means the PR source context monitor will always be included (since the option is non-empty) and will reportmissingif the file isn’t generated in a given run, degrading the overall summary status towarning(peroverallStatus). If this report is truly required everywhere, ensure the workflow always generates that JSON. If it’s optional, consider defaultingpr_source_context_reportto an empty string (opt-in via env/flag) or gating inclusion on file existence rather than option presence.