chore(deps): update stranske/workflows digest to a335f1a - #787
chore(deps): update stranske/workflows digest to a335f1a#787renovate[bot] wants to merge 1 commit into
Conversation
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📜 Recent review details🧰 Additional context used📓 Path-based instructions (2).github/workflows/**/*.yml📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
.github/workflows/agents-*.yml📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🔀 Multi-repo context stranske/WorkflowsBased on my exploration of the Linked repositories findingsstranske/Workflows (Primary Repository)Setup API Client Action Overview: Core Responsibilities:
Input Contract (No Breaking Changes Expected):
Since all inputs are optional, consumers using the fallback action reference at commit Usage Context:
The fallback pin at Current Version: 🔇 Additional comments (1)
📝 WalkthroughWalkthroughTwo lines in ChangesAction SHA Pin Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Workflow state fingerprint for Agents Gate Followups. Do not edit. |
Workflow source neededPR #787 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely. Please do one of:
Once a valid source is present, this warning will not be reposted. |
|
Workflow state fingerprint for Keepalive Loop Reporter. Do not edit. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/agents-guard.yml:
- Line 114: Remove the modifications to the agents-guard.yml file (specifically
the setup-api-client action reference update at line 114 and line 183) from this
pull request, as agent workflow files should not be edited locally in the
consumer repository. Instead, apply these same changes to the corresponding
agents-guard.yml file in the centralized stranske/Workflows repository, which is
the source of truth for all agents-*.yml workflow files. Once the changes are
merged there, the consumer repository will automatically use the updated action
reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f5748bab-4606-4326-8aee-aa0737a9bc38
📒 Files selected for processing (1)
.github/workflows/agents-guard.yml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
stranske/Workflows(auto-detected)
📜 Review details
🧰 Additional context used
📓 Path-based instructions (2)
.github/workflows/**/*.yml
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
.github/workflows/**/*.yml: Do not add top-levelpermissions:block onworkflow_callreusable workflows - this conflicts with caller permissions
Avoid invalid YAML syntax, invalid permission scopes, and circular workflow references when creating GitHub Actions workflows
Files:
.github/workflows/agents-guard.yml
.github/workflows/agents-*.yml
📄 CodeRabbit inference engine (CLAUDE.md)
Agent workflow files (agents-*.yml) should be fixed in stranske/Workflows, not edited locally in the consumer repository
agents-*.yml workflow files should be fixed in stranske/Workflows, not edited locally in the consumer repo
Files:
.github/workflows/agents-guard.yml
| steps.eligibility.outputs.should-run == 'true' && | ||
| steps.api_client_base.outputs.available != 'true' | ||
| uses: "stranske/Workflows/.github/actions/setup-api-client@c2537cc959f2ce05926c4639d25b90678abc97bc" # v1 | ||
| uses: "stranske/Workflows/.github/actions/setup-api-client@44965d8d784573c119fb63828c05c89256c5f3e1" # v1 |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | 🏗️ Heavy lift
Move this agents-guard.yml change to stranske/Workflows instead of patching locally.
Line 114 and Line 183 update an agents-*.yml workflow in the consumer repository, which breaks the repo’s workflow ownership rule and risks divergence from the centrally managed source.
As per coding guidelines, “.github/workflows/agents-*.yml: Agent workflow files (agents-*.yml) should be fixed in stranske/Workflows, not edited locally in the consumer repository.”
Also applies to: 183-183
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/agents-guard.yml at line 114, Remove the modifications to
the agents-guard.yml file (specifically the setup-api-client action reference
update at line 114 and line 183) from this pull request, as agent workflow files
should not be edited locally in the consumer repository. Instead, apply these
same changes to the corresponding agents-guard.yml file in the centralized
stranske/Workflows repository, which is the source of truth for all agents-*.yml
workflow files. Once the changes are merged there, the consumer repository will
automatically use the updated action reference.
Source: Coding guidelines
6f26a33 to
d3d4a44
Compare
|
Closing as superseded by Workflows source fix #2514 plus the next Maint 68 sync wave; this PR patches a managed agents-guard.yml copy directly. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
c2537cc→a335f1aConfiguration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit