Conversation
Automated sync from stranske/Workflows Template hash: 43abb0f65dff Changes synced from sync-manifest.yml
stranske
added
sync
🤖 Keepalive Loop StatusPR #332 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
Keepalive Work Log (click to expand)
|
There was a problem hiding this comment.
Pull request overview
Synchronizes workflow/template content from stranske/Workflows, updating the Claude Code Review workflow metadata and improving the follow-up issue generator’s extraction/output for provider comparison reports.
Changes:
- Extend
followup_issue_generator.pyto capture provider “Summary” from the Provider Summary table, feed non-PASS summaries into extracted concerns, and emit a new “verify:compare” analysis/evidence section in no-LLM output. - Add an inline
# v1annotation to the pinnedanthropics/claude-code-actionreference in the opt-in Claude Code Review workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/langchain/followup_issue_generator.py | Adds parsing/propagation of provider summary text and emits additional analysis/evidence sections in generated follow-up issues. |
| .github/workflows/maint-76-claude-code-review.yml | Adds a version comment to the pinned Claude Code Action reference. |
| if verdict.strip().upper() != "PASS": | ||
| provider_summary_concerns.append(summary_text) |
There was a problem hiding this comment.
When extracting the Provider Summary table, summary_text can be the placeholder "N/A" (see pr_verifier’s table generation). As written, non-PASS rows will add "N/A" into provider_summary_concerns, which then becomes a top-level concern and can generate noisy follow-up tasks. Consider skipping placeholder/empty summaries (e.g., "N/A"), and applying a minimum-length or other sanity filter similar to the other concern extraction paths before appending.
| if verdict.strip().upper() != "PASS": | |
| provider_summary_concerns.append(summary_text) | |
| # Only treat non-placeholder, substantive summaries as concerns. | |
| if verdict.strip().upper() != "PASS": | |
| normalized_summary = summary_text.strip() | |
| is_placeholder = normalized_summary.upper() in { | |
| "N/A", | |
| "NA", | |
| "NONE", | |
| "NO SUMMARY", | |
| } | |
| is_too_short = len(normalized_summary) < 8 | |
| if not is_placeholder and not is_too_short: | |
| provider_summary_concerns.append(summary_text) |
| body_parts.extend( | ||
| [ | ||
| "", | ||
| "## verify:compare Analysis", | ||
| "", | ||
| f"- Resolved verdict: {verdict}", | ||
| ] | ||
| ) | ||
| for concern in blocking_concerns[:10]: | ||
| body_parts.append(f"- Concern: {concern}") | ||
| for concern in advisory_concerns[:10]: | ||
| body_parts.append(f"- Advisory: {concern}") | ||
|
|
||
| body_parts.extend( | ||
| [ | ||
| "", | ||
| "## verify:compare Evidence", | ||
| "", | ||
| ] | ||
| ) |
There was a problem hiding this comment.
The new sections are titled "## verify:compare Analysis" / "## verify:compare Evidence", but _generate_without_llm is used for any no-LLM path (including single-provider verify:evaluate cases). This makes the generated issue misleading. Suggest renaming these headings to something verification-generic (or only emitting the compare-specific headings when multiple providers are present).
| for provider, data in verification_data.provider_verdicts.items(): | ||
| evidence = f"- {provider}: {data.get('verdict', 'Unknown')} @ {data.get('confidence', 0)}%" | ||
| summary = data.get("summary") | ||
| if summary: | ||
| evidence += f" ({summary})" | ||
| body_parts.append(evidence) |
There was a problem hiding this comment.
In the evidence loop, the loop variable name data shadows the surrounding verification_data identifier and is also reused elsewhere in the file for different payload shapes. Renaming it (e.g., provider_payload) would make this section easier to read and reduce confusion during future edits.
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Manifest:
.github/sync-manifest.yml