-
Notifications
You must be signed in to change notification settings - Fork 0
chore: sync workflow templates #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -148,29 +148,6 @@ def _resolve_slots() -> list[SlotDefinition]: | |||||||||||||||||||
| return _apply_slot_env_overrides(_load_slot_config()) | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
||||||||||||||||||||
|
||||||||||||||||||||
| def get_provider_model_catalog() -> list[SlotDefinition]: | |
| """Return the resolved provider/model slot catalog. | |
| This applies the same configuration loading and environment overrides as used | |
| by the LangChain client helpers, ensuring consistent defaults and slot order. | |
| """ | |
| return _resolve_slots() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplicate-removal loop can miss duplicates after the first deletion: removing a later block shifts subsequent duplicates left, potentially to an index before
startIndex + replacement.length, so the nextindexOf(start, ...)search may skip them. Consider restarting the search from just after the first block’s start marker (e.g.,startIndex + 1) each iteration (or otherwise re-scanning until no more matches) so all duplicates are reliably removed.