Skip to content

fix: remove unused typing.Any import (lint F401)#257

Merged
stranske merged 1 commit intocodex/issue-31from
claude/fix-lint-for-256-I1gRT
Feb 26, 2026
Merged

fix: remove unused typing.Any import (lint F401)#257
stranske merged 1 commit intocodex/issue-31from
claude/fix-lint-for-256-I1gRT

Conversation

@stranske
Copy link
Copy Markdown
Owner

@stranske stranske commented Feb 26, 2026

Source: Issue #256

Automated Status Summary

Scope

You want to generate new output types as maintainers change their minds (slides, extra exhibits, etc.) without rewiring everything.

Context for Agent

Related Issues/PRs

Tasks

  • Create src/counter_risk/outputs/base.py defining an OutputGenerator interface for output plugins.
  • Update the historical workbook updater to implement OutputGenerator.
    • Create a new class that wraps the historical workbook updater logic (verify: confirm completion in repo) implements the OutputGenerator interface (verify: confirm completion in repo)
    • Define scope for: Refactor the existing historical workbook update code to use the new OutputGenerator-based class (verify: confirm completion in repo)
    • Implement focused slice for: Refactor the existing historical workbook update code to use the new OutputGenerator-based class (verify: confirm completion in repo)
    • Validate focused slice for: Refactor the existing historical workbook update code to use the new OutputGenerator-based class (verify: confirm completion in repo)
    • Define scope for: Add unit tests to verify the historical workbook OutputGenerator produces the same output as before
    • Implement focused slice for: Add unit tests to verify the historical workbook OutputGenerator produces the same output as before
    • Validate focused slice for: Add unit tests to verify the historical workbook OutputGenerator produces the same output as before
    • Define scope for: Update any calling code to use the new OutputGenerator interface for the historical workbook (verify: confirm completion in repo)
    • Implement focused slice for: Update any calling code to use the new OutputGenerator interface for the historical workbook (verify: confirm completion in repo)
    • Validate focused slice for: Update any calling code to use the new OutputGenerator interface for the historical workbook (verify: confirm completion in repo)
  • Update the PPT screenshot updater to implement OutputGenerator.
    • Create a new class that wraps the PPT screenshot updater logic (verify: confirm completion in repo)
    • Define scope for: Refactor the existing PPT screenshot update code to use the new OutputGenerator-based class (verify: confirm completion in repo)
    • Implement focused slice for: Refactor the existing PPT screenshot update code to use the new OutputGenerator-based class (verify: confirm completion in repo)
    • Validate focused slice for: Refactor the existing PPT screenshot update code to use the new OutputGenerator-based class (verify: confirm completion in repo)
    • Define scope for: Add unit tests to verify the PPT screenshot OutputGenerator produces the same output as before
    • Implement focused slice for: Add unit tests to verify the PPT screenshot OutputGenerator produces the same output as before
    • Validate focused slice for: Add unit tests to verify the PPT screenshot OutputGenerator produces the same output as before
    • Define scope for: Update any calling code to use the new OutputGenerator interface for the PPT screenshot updater (verify: confirm completion in repo)
    • Implement focused slice for: Update any calling code to use the new OutputGenerator interface for the PPT screenshot updater (verify: confirm completion in repo)
    • Validate focused slice for: Update any calling code to use the new OutputGenerator interface for the PPT screenshot updater (verify: confirm completion in repo)
  • Update the PPT link refresher to implement OutputGenerator.
    • Create a new class that wraps the PPT link refresher logic (verify: confirm completion in repo)
    • Define scope for: Refactor the existing PPT link refresh code to use the new OutputGenerator-based class (verify: confirm completion in repo)
    • Implement focused slice for: Refactor the existing PPT link refresh code to use the new OutputGenerator-based class (verify: confirm completion in repo)
    • Validate focused slice for: Refactor the existing PPT link refresh code to use the new OutputGenerator-based class (verify: confirm completion in repo)
    • Define scope for: Add unit tests to verify the PPT link refresher OutputGenerator produces the same output as before
    • Implement focused slice for: Add unit tests to verify the PPT link refresher OutputGenerator produces the same output as before
    • Validate focused slice for: Add unit tests to verify the PPT link refresher OutputGenerator produces the same output as before
    • Define scope for: Update any calling code to use the new OutputGenerator interface for the PPT link refresher (verify: confirm completion in repo)
    • Implement focused slice for: Update any calling code to use the new OutputGenerator interface for the PPT link refresher (verify: confirm completion in repo)
    • Validate focused slice for: Update any calling code to use the new OutputGenerator interface for the PPT link refresher (verify: confirm completion in repo)
  • Add a PDF export generator that uses PowerPoint export via COM if available; otherwise skips with a warning.
    • Create a PDFExportGenerator class that implements the OutputGenerator interface with method stubs (verify: confirm completion in repo)
    • Define scope for: Implement COM availability detection logic to check if PowerPoint COM interface is accessible (verify: confirm completion in repo)
    • Implement focused slice for: Implement COM availability detection logic to check if PowerPoint COM interface is accessible (verify: confirm completion in repo)
    • Validate focused slice for: Implement COM availability detection logic to check if PowerPoint COM interface is accessible (verify: confirm completion in repo)
    • Add PowerPoint to PDF export functionality using COM automation when available (verify: confirm completion in repo)
    • Implement graceful fallback behavior that logs a warning (verify: confirm completion in repo) skips PDF generation when COM is unavailable (verify: confirm completion in repo)
    • Add unit tests for the PDF export generator covering both COM available (verify: tests pass) unavailable scenarios (verify: confirm completion in repo)
  • Add configuration to enable/disable specific outputs per run and register output generators via config.
    • Define configuration schema for output generators including enable/disable flags (verify: config validated)
    • Define configuration schema for output generators including registration details (verify: config validated)
    • Implement a registry mechanism that loads (verify: confirm completion in repo) stores OutputGenerator instances from configuration (verify: config validated)
    • Add runtime logic to filter enabled output generators based on configuration settings (verify: config validated)
    • Update configuration documentation to explain how to register (verify: docs updated) enable/disable output generators (verify: confirm completion in repo)
    • Add integration tests that verify outputs can be selectively enabled disabled via configuration (verify: config validated)

Acceptance criteria

  • Implementing a single OutputGenerator class and registering it in config adds a new output without requiring changes to other outputs.
  • Disabling an output via config does not break the pipeline run.

Head SHA: 602948e
Latest Runs: ❔ in progress — Gate
Required: gate: ❔ in progress

Workflow / Job Result Logs
.github/workflows/autofix.yml ❌ failure View run
Agents PR Event Hub ⏭️ skipped View run
Agents PR Meta ❔ in progress View run
Copilot code review ❔ in progress View run
Dependabot Auto-merge ⏭️ skipped View run
Gate ❔ in progress View run
Health 45 Agents Guard ✅ success View run

The merge conflict resolution in 073de24 left an unused `from typing
import Any` in test_normalization_registry_first.py, causing the
lint-ruff Gate check to fail.

https://claude.ai/code/session_01JhCWWDJG8PqwaSbVPCGfm6
Copilot AI review requested due to automatic review settings February 26, 2026 00:51
@stranske stranske merged commit 407f7de into codex/issue-31 Feb 26, 2026
37 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused from typing import Any import from the test file tests/test_normalization_registry_first.py that was inadvertently left behind during a merge conflict resolution in commit 073de24. The unused import was causing the lint-ruff Gate check to fail on PR #256.

Changes:

  • Remove unused from typing import Any import to fix ruff F401 lint error

@stranske-keepalive
Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #257 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Disposition skipped (transient)
Gate success
Tasks 12/51 complete
Timeout 45 min (default)
Timeout usage 7m elapsed (18%, 38m remaining)
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

@stranske-keepalive
Copy link
Copy Markdown
Contributor

Keepalive Work Log (click to expand)
# Time (UTC) Agent Action Result Files Tasks Progress Commit Gate
0 2026-02-26 00:59:07 Codex wait (missing-agent-label-transient) skipped 0 12/51 success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants