46 #209
Closed
46 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2022
|
@faddat thanks for the PR afaik we aren't upgrading sdk version here quite yet. thanks for the start on it tho! |
|
Hey @faddat thanks for this. @mark-rushakoff did this work in a different branch. Yours helped us get started. I'm going to go ahead and close this.#235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a partial upgrade to sdk 46 for ibctest. The only place where it's incomplete is in the keyring generation, which now require the chain's client context and inbuf.NewBuf(cmd) <- don't know where to get cmd
Checklist
Changes
Screenshots
...
Testing
Links/References
Notes