fix(swarm): pass actual tool objects instead of tool name strings to sub-agents #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sub-agents - Fixed bug where swarm tool was passing tool names as strings to sub-agents - Sub-agents were treating strings as file paths and trying to load ./shell.py etc. - Now retrieves actual tool objects from parent_agent.tool_registry.registry - Added test to verify tool objects are passed correctly - Resolves 'Tool file not found' errors in swarm sub-agents Fixes issue reported by Aaron Brown where sub-agents couldn't use tools
jer96
previously approved these changes
Jul 22, 2025
The test was failing due to timing variations where actual sleep time exceeded the expected 0.7 second upper bound. Removed the test and unused time import to fix test reliability.
cagataycali
commented
Jul 22, 2025
jer96
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a critical bug in the swarm tool where sub-agents were receiving tool names as strings instead of actual tool objects from the parent agent's registry. This caused sub-agents to treat tool names like "shell" and "editor" as file paths, attempting to load files like
./shell.pyand resulting in "Tool file not found" errors.The fix modifies
_create_custom_agents()to properly retrieve actual tool objects fromparent_agent.tool_registry.registryinstead of passing tool name strings, ensuring sub-agents receive functional tool instances.Thanks for reporting: @westonbrown
Related Issues
Addresses bug reported by Aaron Brown regarding swarm sub-agents being unable to use tools due to incorrect tool object passing.
Documentation PR
[Link to related associated PR in the agent-docs repo - if needed]
Type of Change
Testing
The change has been thoroughly tested with:
hatch fmt --linter✅hatch fmt --formatter✅hatch test --all✅Added comprehensive unit test
test_create_agents_tool_objects_retrieval()that verifies:Checklist
I have read the CONTRIBUTING document
I have added tests that prove my fix is effective or my feature works
I have updated the documentation accordingly
I have added an appropriate example to the documentation to outline the feature
My changes generate no new warnings
Any dependent changes have been merged and published
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.