feat(hooks): Mark ModelCall and ToolCall events as non-experimental #926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #667 - we haven't seen any huge deficiencies in these and we need to stabilize hooks
As part of this change we renamed the events to clarify naming and reduce verbosity:
BeforeToolInvocationEvent->BeforeToolCallEventAfterToolInvocationEvent->AfterToolCallEventBeforeModelInvocationEvent->BeforeModelCallEventAfterModelInvocationEvent->AfterModelCallEventPart of the motivation of the rename is to avoid confusion with BeforeInvocationEvent and BeforeToolInvocation & BeforeModelInvocationEvent, as we've seen folks confusing them quite a bit.
API Bar Raise
The new names need to be API bar-raised.
The existing events that are not changing are as follows:
AgentInitializedEventAgent.__init__.BeforeInvocationEvent__call__,stream_async, orstructured_output)AfterInvocationEventMessageAddedEventThe proposed events that are being renamed:
BeforeModelInvocationEventBeforeModelCallEventAfterModelInvocationEventAfterModelCallEventBeforeToolInvocationEventBeforeToolCallEventAfterToolInvocationEventAfterToolCallEventBackwards compatibility
Related Issues
#667
Documentation PR
TBD
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.