fix: prevent path traversal for message_id in file_session_manager #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
pgrayy
approved these changes
Aug 25, 2025
dbschmigelski
pushed a commit
to dbavro19/sdk-python
that referenced
this pull request
Aug 28, 2025
…trands-agents#728) * fix: prevent path traversal for message_id in file_session_manager * fix: prevent path traversal for message_id in session managers * fix: prevent path traversal for message_id in session managers
7 tasks
This was referenced Sep 17, 2025
Closed
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Sep 24, 2025
…trands-agents#728) * fix: prevent path traversal for message_id in file_session_manager * fix: prevent path traversal for message_id in session managers * fix: prevent path traversal for message_id in session managers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing a path_traversal security issue in
FileSessionManagerandS3SessionManagerspecifically in our_get_message_path()method. Currently we don't validate themessage_idbut we do validate the other id's such assession_idandagent_idRelated Issues
This PR fixes the issue by raising an exception if the message_id contains separators.
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.