generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 458
fix(event_loop): ensure tool_use content blocks are valid after max_tokens to prevent unrecoverable state #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dbschmigelski
merged 26 commits into
strands-agents:main
from
dbschmigelski:hook-provider
Aug 8, 2025
Merged
Changes from 22 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
c5e4e51
fix(event_loop): raise dedicated exception when encountering max toke…
dbschmigelski 6703819
fix: update integ tests
dbschmigelski c94b74e
fix: rename exception message, add to exception, move earlier in cycle
dbschmigelski 36dd0f9
Update tests_integ/test_max_tokens_reached.py
dbschmigelski e04c73d
Update tests_integ/test_max_tokens_reached.py
dbschmigelski cca2f86
linting
dbschmigelski f647baa
Merge branch 'strands-agents:main' into fix-max-tokens
dbschmigelski 78c5a91
Merge branch 'strands-agents:main' into fix-max-tokens
dbschmigelski a208496
Merge branch 'strands-agents:main' into fix-max-tokens
dbschmigelski 2e2d4df
feat: add builtin hook provider to address max tokens reached truncation
dbschmigelski 447d147
tests: modify integ test to inspect message history
dbschmigelski 564895d
fix: fix linting errors
dbschmigelski 2f118fb
fix: linting
dbschmigelski e5fc51a
refactor: switch from hook approach to conversation manager
dbschmigelski 5906fc2
linting
dbschmigelski 87445a3
fix: test contained incorrect assertions
dbschmigelski 924fea9
fix: add event emission
dbschmigelski 104f6b4
feat: move to async
dbschmigelski 11b91f4
feat: add additional error case where no tool uses were fixed
dbschmigelski 1da9ba7
feat: add max tokens reached test
dbschmigelski 623f3c7
linting
dbschmigelski 66c4c07
feat: add max tokens reached test
dbschmigelski 4b5c5a7
feat: switch to a default behavior to recover from max tokens reached
dbschmigelski 83ad822
fix: all tool uses now must be replaced
dbschmigelski faa4618
fix: boolean
dbschmigelski fa8195f
remove todo
dbschmigelski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
src/strands/agent/conversation_manager/recover_tool_use_on_max_tokens_reached.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| """Shared utility for handling token limit recovery in conversation managers.""" | ||
|
|
||
| import logging | ||
| from typing import TYPE_CHECKING | ||
|
|
||
| from ...hooks import MessageAddedEvent | ||
| from ...types.content import ContentBlock, Message | ||
| from ...types.exceptions import MaxTokensReachedException | ||
| from ...types.tools import ToolUse | ||
|
|
||
| if TYPE_CHECKING: | ||
| from ...agent.agent import Agent | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| async def recover_tool_use_on_max_tokens_reached(agent: "Agent", exception: MaxTokensReachedException) -> None: | ||
| """Handle MaxTokensReachedException by cleaning up orphaned tool uses and adding corrected message. | ||
|
|
||
| This function fixes incomplete tool uses that may occur when the model's response is truncated | ||
| due to token limits. It: | ||
|
|
||
| 1. Inspects each content block in the incomplete message for invalid tool uses | ||
| 2. Replaces incomplete tool use blocks with informative text messages | ||
| 3. Preserves valid content blocks in the corrected message | ||
| 4. Adds the corrected message to the agent's conversation history | ||
|
|
||
| Args: | ||
| agent: The agent whose conversation will be updated with the corrected message. | ||
| exception: The MaxTokensReachedException containing the incomplete message. | ||
| """ | ||
| logger.info("handling MaxTokensReachedException - inspecting incomplete message for invalid tool uses") | ||
|
|
||
| incomplete_message: Message = exception.incomplete_message | ||
dbschmigelski marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| if not incomplete_message["content"]: | ||
| # Cannot correct invalid content block if content is empty | ||
| raise exception | ||
|
|
||
| valid_content: list[ContentBlock] = [] | ||
| for content in incomplete_message["content"]: | ||
| tool_use: ToolUse | None = content.get("toolUse") | ||
| if not tool_use: | ||
| valid_content.append(content) | ||
| continue | ||
|
|
||
| # Check if tool use is incomplete (missing or empty required fields) | ||
| tool_name = tool_use.get("name") | ||
| if not (tool_name and tool_use.get("input") and tool_use.get("toolUseId")): | ||
| # Tool use is incomplete due to max_tokens truncation | ||
| display_name = tool_name if tool_name else "<unknown>" | ||
| logger.warning("tool_name=<%s> | replacing with error message due to max_tokens truncation.", display_name) | ||
|
|
||
| valid_content.append( | ||
| { | ||
| "text": f"The selected tool {display_name}'s tool use was incomplete due " | ||
| f"to maximum token limits being reached." | ||
| } | ||
| ) | ||
| else: | ||
| # ToolUse was invalid for an unknown reason. Cannot correct, return without modifying | ||
| raise exception | ||
|
|
||
| valid_message: Message = {"content": valid_content, "role": incomplete_message["role"]} | ||
| agent.messages.append(valid_message) | ||
| agent.hooks.invoke_callbacks(MessageAddedEvent(agent=agent, message=valid_message)) | ||
dbschmigelski marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| # Test package for conversation manager |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.