Skip to content

Conversation

@zastrowm
Copy link
Member

@zastrowm zastrowm commented Jul 9, 2025

Description

Move tests to tests_integ as tests-integ is not a proper module name. Also extract all provider ignoring to a new providers file which centralizes the environment variables needed.

Notes:

pytestmark = ...

Can be used to ignore an entire set of tests if a given condition isn't true, which what we leverage here.

Related Issues

N/A

Documentation PR

N/A

Type of Change

Other (please describe): Refactor

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Move tests to `tests_integ` as `tests-integ` is not a proper module name.  Also extract all provider ignoring to a new providers file which centralizes the environment variables needed.
dbschmigelski
dbschmigelski previously approved these changes Jul 9, 2025
Copy link
Member

@dbschmigelski dbschmigelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love pytestmark here!

dbschmigelski
dbschmigelski previously approved these changes Jul 9, 2025
@zastrowm zastrowm merged commit b26aecb into strands-agents:main Jul 9, 2025
22 of 24 checks passed
malte-aws pushed a commit to malte-aws/sdk-python that referenced this pull request Jul 10, 2025
Move tests to `tests_integ` as `tests-integ` is not a proper module name.  Also extract all provider ignoring to a new providers file which centralizes the environment variables needed.
dbschmigelski pushed a commit to Ketansuhaas/sdk-python that referenced this pull request Jul 24, 2025
Move tests to `tests_integ` as `tests-integ` is not a proper module name.  Also extract all provider ignoring to a new providers file which centralizes the environment variables needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants