refactor: remove kwargs spread after agent call #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
previously approved these changes
Jun 25, 2025
Merged
zastrowm
reviewed
Jun 27, 2025
zastrowm
previously approved these changes
Jun 27, 2025
zastrowm
approved these changes
Jun 27, 2025
3 tasks
jsamuel1
pushed a commit
to jsamuel1/sdk-python
that referenced
this pull request
Jul 9, 2025
* refactor: remove kwargs spread after agent call * fix: Add local method override * fix: fix unit tests
dbschmigelski
pushed a commit
to Ketansuhaas/sdk-python
that referenced
this pull request
Jul 24, 2025
* refactor: remove kwargs spread after agent call * fix: Add local method override * fix: fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors how kwargs are handled within the Agent class. Instead of allowing certain override parameters to be passed in via kwargs, we instead rely on the agent's attributes. After invoking an agent, or using a direct tool call, the kwargs are passed around as a dict instead of being spread.
Related Issues
N/A
Documentation PR
TODO if there are any docs changes needed
Type of Change
Breaking change
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.