Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions strands-ts/src/telemetry/__tests__/tracer.test.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,27 @@ describe('Tracer', () => {
expect(mockSpan.getAttributeValue('gen_ai.usage.completion_tokens')).toBe(200)
})

// Accumulated usage folds cached tokens into input_tokens for disjoint-cache providers,
// matching the per-invocation span (OTel GenAI semconv).
it('includes cached tokens in accumulated input_tokens for disjoint-cache providers', () => {
const tracer = new Tracer()
const span = tracer.startAgentSpan({ messages: [textMessage('user', 'Hi')], agentName: 'agent' })

tracer.endAgentSpan(span, {
accumulatedUsage: {
inputTokens: 10,
outputTokens: 20,
totalTokens: 58,
cacheReadInputTokens: 25,
cacheWriteInputTokens: 3,
},
})

expect(mockSpan.getAttributeValue('gen_ai.usage.input_tokens')).toBe(38)
expect(mockSpan.getAttributeValue('gen_ai.usage.prompt_tokens')).toBe(38)
expect(mockSpan.getAttributeValue('gen_ai.usage.total_tokens')).toBe(58)
})

it('adds response event with stable conventions', () => {
const tracer = new Tracer()
const span = tracer.startAgentSpan({ messages: [textMessage('user', 'Hi')], agentName: 'agent' })
Expand Down Expand Up @@ -331,6 +352,45 @@ describe('Tracer', () => {
expect(mockSpan.getAttributeValue('gen_ai.server.request.duration')).toBe(500)
})

// input_tokens must include cached tokens per the OTel GenAI semconv; disjoint-cache
// providers (Bedrock Converse, Anthropic-direct) report them separately, so fold them in.
it('includes cached tokens in input_tokens for disjoint-cache providers', () => {
const tracer = new Tracer()
const span = tracer.startModelInvokeSpan({ messages: [textMessage('user', 'Hi')] })

tracer.endModelInvokeSpan(span, {
usage: {
inputTokens: 10,
outputTokens: 20,
totalTokens: 58,
cacheReadInputTokens: 25,
cacheWriteInputTokens: 3,
},
})

expect(mockSpan.getAttributeValue('gen_ai.usage.input_tokens')).toBe(38)
expect(mockSpan.getAttributeValue('gen_ai.usage.prompt_tokens')).toBe(38)
expect(mockSpan.getAttributeValue('gen_ai.usage.output_tokens')).toBe(20)
expect(mockSpan.getAttributeValue('gen_ai.usage.total_tokens')).toBe(58)
expect(mockSpan.getAttributeValue('gen_ai.usage.cache_read.input_tokens')).toBe(25)
expect(mockSpan.getAttributeValue('gen_ai.usage.cache_creation.input_tokens')).toBe(3)
})

// Subset-cache providers (OpenAI, Gemini) already count cache inside input_tokens;
// the fold-in must be a no-op so cached tokens are not counted twice.
it('does not double-count when the provider already includes cache in input_tokens', () => {
const tracer = new Tracer()
const span = tracer.startModelInvokeSpan({ messages: [textMessage('user', 'Hi')] })

tracer.endModelInvokeSpan(span, {
usage: { inputTokens: 100, outputTokens: 20, totalTokens: 120, cacheReadInputTokens: 30 },
})

expect(mockSpan.getAttributeValue('gen_ai.usage.input_tokens')).toBe(100)
expect(mockSpan.getAttributeValue('gen_ai.usage.prompt_tokens')).toBe(100)
expect(mockSpan.getAttributeValue('gen_ai.usage.cache_read.input_tokens')).toBe(30)
})

it('sets cache token attributes when provided', () => {
const tracer = new Tracer()
const span = tracer.startModelInvokeSpan({ messages: [textMessage('user', 'Hi')] })
Expand Down
6 changes: 4 additions & 2 deletions strands-ts/src/telemetry/tracer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ import type { ContentBlock, Message, SystemPrompt } from '../types/messages.js'
import type { JSONSerializable } from '../types/json.js'
import { jsonReplacer } from './json.js'
import { getServiceName } from './utils.js'
import { totalPromptTokens } from '../models/streaming.js'

/**
* JSON-serializable representation of LocalTrace.
Expand Down Expand Up @@ -1132,8 +1133,9 @@ export class Tracer {
* attribute names for compatibility with different OTEL backends.
*/
private _setUsageAttributes(attributes: Record<string, AttributeValue>, usage: Usage): void {
attributes['gen_ai.usage.prompt_tokens'] = usage.inputTokens
attributes['gen_ai.usage.input_tokens'] = usage.inputTokens
const promptTokens = totalPromptTokens(usage)
attributes['gen_ai.usage.prompt_tokens'] = promptTokens
attributes['gen_ai.usage.input_tokens'] = promptTokens
attributes['gen_ai.usage.completion_tokens'] = usage.outputTokens
attributes['gen_ai.usage.output_tokens'] = usage.outputTokens
attributes['gen_ai.usage.total_tokens'] = usage.totalTokens
Expand Down
Loading