fix: read prompt_tokens_details cache reads in TS OpenAI Chat - #3885
Merged
opieter-aws merged 2 commits intoAug 19, 2026
Merged
opieter-aws merged 2 commits into
opieter-aws merged 2 commits into
Conversation
Removed outdated regression comment regarding TS Chat.
mehtarac
approved these changes
Aug 19, 2026
Contributor
|
Assessment: Approve Clean, well-scoped bug fix that closes the py/ts Chat parity gap for prompt-cache reads. The new guard mirrors the Responses path ( Review Notes
Nice job keeping this tightly aligned with the existing Responses implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TypeScript OpenAI Chat Completions path doesn't read
prompt_tokens_details.cached_tokens, so prompt-cache reads were invisible in its usageRelated Issues
Part of the #3546 usage-accounting work (the py/ts Chat parity gap).
Documentation PR
N/A
Type of Change
Bug fix
Testing
Ran the TS OpenAI Chat unit suite (
src/models/openai/__tests__/chat.test.ts), covering a cached-read payload surfacingcacheReadInputTokensand a zero/absent case that must not introduce the field.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.