Skip to content

chore(bidi): bump google-genai floor to >=1.67.0 - #3478

Merged
mehtarac merged 2 commits into
strands-agents:mainfrom
mehtarac:update_genai
Jul 24, 2026
Merged

mehtarac merged 2 commits into
strands-agents:mainfrom
mehtarac:update_genai

Conversation

@mehtarac

Copy link
Copy Markdown
Member

Description

HistoryConfig (used for Gemini 3.1 history seeding in #3424) requires google-genai 1.67+. The previous floor of 1.32.0 allowed installations where genai_types.HistoryConfig raises AttributeError.

Related Issues

Documentation PR

Type of Change

Bug fix
New feature
Breaking change
Documentation update
Other (please describe):

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce new warnings.

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have reviewed and understand every line of code in this PR, including any generated by AI tools, and I can explain why it works
  • My change is focused and reasonably small; I have split unrelated work into separate PRs
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mehtarac
mehtarac requested a review from a team as a code owner July 24, 2026 21:09
@mehtarac
mehtarac requested a review from pgrayy July 24, 2026 21:09
@github-actions github-actions Bot added size/xs python Pull requests that update python code area-bidirectional-streaming Related to bidirectional streaming area-model Related to models or model providers chore Maintenance tasks, dependency updates, CI changes, refactoring with no user-facing impact labels Jul 24, 2026
Comment thread strands-py/pyproject.toml
@github-actions

Copy link
Copy Markdown
Contributor

Assessment: Request Changes

The version floor (1.67.0) is correct, but it was applied to the wrong optional-dependency group, so the PR doesn't actually fix the problem it describes.

Review Details
  • Correctness (blocking): HistoryConfig is used by the bidi Gemini Live provider (experimental/bidi/models/gemini_live.py, per fix(bidi): gemini live mp to use updated api #3424), which is installed via the bidi-gemini extra (line 87 — still >=1.32.0). This PR bumped the gemini extra (line 50) instead. The affected users ([bidi-gemini]/[bidi-all]) would still install 1.32.0 and hit the AttributeError. See inline comment.
  • Version claim: Verified — history_config/initial_history_in_client_content shipped in google-genai v1.67.0.
  • Dependency bounds: Upper bound <3.0.0 retained.
  • Ordering: fix(bidi): gemini live mp to use updated api #3424 (the code that requires 1.67+) is still open; this bump should land with/after it.
  • Tests/API review: N/A for a dependency floor bump.

Small, well-scoped change — just needs to target the bidi-gemini extra.

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread strands-py/pyproject.toml
@github-actions

Copy link
Copy Markdown
Contributor

Assessment: Request Changes

The version floor >=1.67.0 is correct (verified: HistoryConfig first appears in google-genai 1.67.0), but the bump was applied to the wrong optional-dependency extra.

Review Details
  • Correctness (blocking): HistoryConfig is used by the bidi Gemini Live model, which is installed via the bidi-gemini extra (line 87) — that line was not changed and still allows google-genai==1.32.0. The change instead landed on the non-bidi gemini extra (line 50), which doesn't use HistoryConfig. Bidi users would still hit the AttributeError. See inline comment.
  • Dependency bounds: Upper bound <3.0.0 correctly retained. 👍
  • Testing/docs: None needed for a dependency-bound change.

Small, well-motivated change — just needs to target the bidi-gemini extra to actually resolve the issue.

@mehtarac
mehtarac merged commit ec1c0db into strands-agents:main Jul 24, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-bidirectional-streaming Related to bidirectional streaming area-model Related to models or model providers chore Maintenance tasks, dependency updates, CI changes, refactoring with no user-facing impact python Pull requests that update python code size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants