ci: update langfuse requirement from <4,>=2.0.0 to >=2.0.0,<5 - #367
ci: update langfuse requirement from <4,>=2.0.0 to >=2.0.0,<5#367dependabot[bot] wants to merge 1 commit into
Conversation
|
@strandly-the-agent is this PR safe to merge? |
|
TL;DR: 🔴 Not safe to merge. langfuse 4.x breaks Repro against real langfuse 4.14.4 (no network needed — fails at the call signature): Recommendation: keep Verification detailsWhat I checked (head
from strands_evals.providers.langfuse_provider import LangfuseProvider
p = LangfuseProvider(public_key="pk", secret_key="sk", host="https://example.invalid")
p._fetch_observations("some-trace-id")
# TypeError: ObservationsClient.get_many() got an unexpected keyword argument 'page'Why CI didn't catch it: Second issue even after a pagination fix: in SDK v4, Also note: the resulting range |
Updates the requirements on [langfuse](https://github.com/langfuse/langfuse) to permit the latest version. - [Release notes](https://github.com/langfuse/langfuse/releases) - [Commits](https://github.com/langfuse/langfuse/commits) --- updated-dependencies: - dependency-name: langfuse dependency-version: 4.14.3 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dbe4bdb to
fe97d60
Compare
Updates the requirements on langfuse to permit the latest version.
Commits